Fix some features and styles that don't work properly on some devices#261
Open
ShiYioo wants to merge 2 commits into
Open
Fix some features and styles that don't work properly on some devices#261ShiYioo wants to merge 2 commits into
ShiYioo wants to merge 2 commits into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your tutorial and solution code doesn't seem to work on my emulator, your code may not work properly on some devices or other factors, I try to fix it and give a new solution code
When I try to enter values in the keyboard, it seems to generate a lot of GameViewModel instances on the run, and the init block keeps running, all of which I set to singleton mode
The gameUiState variable declared by val in GameScreen.kt, my Android Studio tells me that it can't pass by delegate, I've tried to fix it and it works perfectly
Also, I fixed some styling bugs in the tutorial,modifier = modifier.align(Alignment.CenterHorizontally) is changed to modifier = Modifier.align(Alignment.CenterHorizontally)