Fixing Update Logic#41
Open
ManasMalla wants to merge 1 commit into
Open
Conversation
On validating the last question, when we don't pick a new question, don't increment the currentWordCount and when initializing the ViewModel and setting up the first question, increment the currentWordCount as 1. Then the test cases given in the codelab work out of the box
I think the bug is in the test, not in the main app code. I think the test needs to be updated to: In section 2 (App Overview), it says that "the app displays the word count, which is the number of scrambled words played in the current game" - which to me implies that it does correctly show 0 when starting, because you haven't yet played (past tense) a word yet, and in this case I would expect it to show 9 of 10 when I'm on the last word of the game (though intuitive this may be). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Then the test cases given in the codelab work out of the box.