Migrate core render util to use xterm.js as part of the rendering loop. (#19044)

Author: jacob314

package-lock.json

@@ -64,7 +64,7 @@
     "pre-commit": "node scripts/pre-commit.js"
   },
   "overrides": {
-    "ink": "npm:@jrichman/ink@6.4.10",
+    "ink": "npm:@jrichman/ink@6.4.11",
     "wrap-ansi": "9.0.2",
     "cliui": {
       "wrap-ansi": "7.0.0"
@@ -107,7 +107,6 @@
     "globals": "^16.0.0",
     "google-artifactregistry-auth": "^3.4.0",
     "husky": "^9.1.7",
-    "ink-testing-library": "^4.0.0",
     "json": "^11.0.0",
     "lint-staged": "^16.1.6",
     "memfs": "^4.42.0",
@@ -127,7 +126,7 @@
     "yargs": "^17.7.2"
   },
   "dependencies": {
-    "ink": "npm:@jrichman/ink@6.4.10",
+    "ink": "npm:@jrichman/ink@6.4.11",
     "latest-version": "^9.0.0",
     "proper-lockfile": "^4.1.2",
     "simple-git": "^3.28.0"

package.json

@@ -48,7 +48,7 @@
     "fzf": "^0.5.2",
     "glob": "^12.0.0",
     "highlight.js": "^11.11.1",
-    "ink": "npm:@jrichman/ink@6.4.10",
+    "ink": "npm:@jrichman/ink@6.4.11",
     "ink-gradient": "^3.0.0",
     "ink-spinner": "^5.0.0",
     "latest-version": "^9.0.0",
@@ -80,7 +80,7 @@
     "@types/shell-quote": "^1.7.5",
     "@types/ws": "^8.5.10",
     "@types/yargs": "^17.0.32",
-    "ink-testing-library": "^4.0.0",
+    "@xterm/headless": "^5.5.0",
     "typescript": "^5.3.3",
     "vitest": "^3.1.1"
   },

packages/cli/package.json

@@ -269,7 +269,7 @@ describe('github.ts', () => {
 
     it('should return NOT_UPDATABLE if local extension config cannot be loaded', async () => {
       vi.mocked(mockExtensionManager.loadExtensionConfig).mockImplementation(
-        () => {
+        async () => {
           throw new Error('Config not found');
         },
       );

packages/cli/src/config/extensions/github.test.ts

@@ -491,25 +491,33 @@ describe('Trusted Folders', () => {
     });
   });
 
+  const itif = (condition: boolean) => (condition ? it : it.skip);
+
   describe('Symlinks Support', () => {
     const mockSettings: Settings = {
       security: { folderTrust: { enabled: true } },
     };
 
-    it('should trust a folder if the rule matches the realpath', () => {
-      // Create a real directory and a symlink
-      const realDir = path.join(tempDir, 'real');
-      const symlinkDir = path.join(tempDir, 'symlink');
-      fs.mkdirSync(realDir);
-      fs.symlinkSync(realDir, symlinkDir);
-
-      // Rule uses realpath
-      const config = { [realDir]: TrustLevel.TRUST_FOLDER };
-      fs.writeFileSync(trustedFoldersPath, JSON.stringify(config), 'utf-8');
-
-      // Check against symlink path
-      expect(isWorkspaceTrusted(mockSettings, symlinkDir).isTrusted).toBe(true);
-    });
+    // TODO: issue 19387 - Enable symlink tests on Windows
+    itif(process.platform !== 'win32')(
+      'should trust a folder if the rule matches the realpath',
+      () => {
+        // Create a real directory and a symlink
+        const realDir = path.join(tempDir, 'real');
+        const symlinkDir = path.join(tempDir, 'symlink');
+        fs.mkdirSync(realDir);
+        fs.symlinkSync(realDir, symlinkDir);
+
+        // Rule uses realpath
+        const config = { [realDir]: TrustLevel.TRUST_FOLDER };
+        fs.writeFileSync(trustedFoldersPath, JSON.stringify(config), 'utf-8');
+
+        // Check against symlink path
+        expect(isWorkspaceTrusted(mockSettings, symlinkDir).isTrusted).toBe(
+          true,
+        );
+      },
+    );
   });
 
   describe('Verification: Auth and Trust Interaction', () => {

packages/cli/src/config/trustedFolders.test.ts

@@ -5,6 +5,7 @@
  */
 
 import { describe, it, afterEach, expect } from 'vitest';
+import { act } from 'react';
 import { AppRig } from './AppRig.js';
 import path from 'node:path';
 import { fileURLToPath } from 'node:url';
@@ -68,7 +69,11 @@ describe('AppRig', () => {
     );
     rig = new AppRig({ fakeResponsesPath });
     await rig.initialize();
-    rig.render();
+    await act(async () => {
+      rig!.render();
+      // Allow async initializations (like banners) to settle within the act boundary
+      await new Promise((resolve) => setTimeout(resolve, 0));
+    });
 
     // Wait for initial render
     await rig.waitForIdle();

packages/cli/src/test-utils/AppRig.test.tsx

@@ -501,7 +501,7 @@ export class AppRig {
 
   get lastFrame() {
     if (!this.renderResult) return '';
-    return stripAnsi(this.renderResult.lastFrame() || '');
+    return stripAnsi(this.renderResult.lastFrame({ allowEmpty: true }) || '');
   }
 
   getStaticOutput() {