fix(core): ensure edit and write-file tools use storage.getPlansDir

This fixes test failures introduced during conflict resolution by strictly calling storage.getPlansDir as per the new config architecture.

Author: mahimashanware

packages/core/src/tools/edit.ts

@@ -469,9 +469,9 @@ class EditToolInvocation
       try {
         this.resolvedPath = resolveAndValidatePlanPath(
           this.params.file_path,
-          this.config.getPlansDir(),
+          this.config.storage.getPlansDir(),
         );
-      } catch (e) {
+      } catch {
         // Validation fails, set resolvedPath to something that will fail validation downstream or just the raw path.
         // It's safer to store it so validation in execute() or getConfirmationDetails() catches it.
         this.resolvedPath = this.params.file_path;
@@ -1064,7 +1064,7 @@ export class EditTool
       try {
         resolvedPath = resolveAndValidatePlanPath(
           params.file_path,
-          this.config.getPlansDir(),
+          this.config.storage.getPlansDir(),
         );
       } catch (err) {
         return err instanceof Error ? err.message : String(err);

packages/core/src/tools/exit-plan-mode.ts

@@ -66,14 +66,14 @@ export class ExitPlanModeTool extends BaseDeclarativeTool<
     try {
       resolveAndValidatePlanPath(
         params.plan_filename,
-        this.config.getPlansDir(),
+        this.config.storage.getPlansDir(),
       );
     } catch (e) {
       if (e instanceof Error && e.message.startsWith('Security violation')) {
         return `Access denied: plan path (${path.join(
-          this.config.getPlansDir(),
+          this.config.storage.getPlansDir(),
           params.plan_filename,
-        )}) must be within the designated plans directory (${this.config.getPlansDir()}).`;
+        )}) must be within the designated plans directory (${this.config.storage.getPlansDir()}).`;
       }
       return e instanceof Error ? e.message : String(e);
     }
@@ -126,7 +126,7 @@ export class ExitPlanModeInvocation extends BaseToolInvocation<
 
     const pathError = await validatePlanPath(
       this.params.plan_filename,
-      this.config.getPlansDir(),
+      this.config.storage.getPlansDir(),
     );
     if (pathError) {
       this.planValidationError = pathError;
@@ -176,7 +176,7 @@ export class ExitPlanModeInvocation extends BaseToolInvocation<
   }
 
   getDescription(): string {
-    return `Requesting plan approval for: ${path.join(this.config.getPlansDir(), this.params.plan_filename)}`;
+    return `Requesting plan approval for: ${path.join(this.config.storage.getPlansDir(), this.params.plan_filename)}`;
   }
 
   /**
@@ -186,7 +186,7 @@ export class ExitPlanModeInvocation extends BaseToolInvocation<
   private getResolvedPlanPath(): string {
     return resolveAndValidatePlanPath(
       this.params.plan_filename,
-      this.config.getPlansDir(),
+      this.config.storage.getPlansDir(),
     );
   }
 

packages/core/src/tools/write-file.ts

@@ -172,9 +172,9 @@ class WriteFileToolInvocation extends BaseToolInvocation<
       try {
         this.resolvedPath = resolveAndValidatePlanPath(
           this.params.file_path,
-          this.config.getPlansDir(),
+          this.config.storage.getPlansDir(),
         );
-      } catch (e) {
+      } catch {
         // Validation fails, set resolvedPath to something that will fail validation downstream or just the raw path.
         this.resolvedPath = this.params.file_path;
       }
@@ -509,7 +509,7 @@ export class WriteFileTool
       try {
         resolvedPath = resolveAndValidatePlanPath(
           filePath,
-          this.config.getPlansDir(),
+          this.config.storage.getPlansDir(),
         );
       } catch (err) {
         return err instanceof Error ? err.message : String(err);