fix(core): add timeouts and trimming to proxy agents

Author: cocosheng-g

packages/core/src/utils/fetch.test.ts

@@ -33,6 +33,7 @@ const {
   isAddressPrivate,
   fetchWithTimeout,
   setGlobalProxy,
+  createSafeProxyAgent,
 } = await import('./fetch.js');
 interface ErrorWithCode extends Error {
   code?: string;
@@ -55,6 +56,7 @@ describe('fetch utils', () => {
       return [{ address: '93.184.216.34', family: 4 }];
     });
     vi.unstubAllEnvs();
+    updateGlobalFetchTimeouts(60000);
   });
 
   afterEach(() => {
@@ -239,17 +241,17 @@ describe('fetch utils', () => {
 
   describe('setGlobalProxy', () => {
     it('should configure EnvHttpProxyAgent with experiment flag timeout and noProxy', () => {
-      const proxyUrl = 'http://proxy.example.com';
-      const noProxyValue = 'localhost,127.0.0.1';
+      const proxyUrl = ' http://proxy.example.com ';
+      const noProxyValue = ' localhost,127.0.0.1 ';
       vi.stubEnv('NO_PROXY', noProxyValue);
 
       updateGlobalFetchTimeouts(45773134);
       setGlobalProxy(proxyUrl);
 
       expect(EnvHttpProxyAgent).toHaveBeenCalledWith({
-        httpProxy: proxyUrl,
-        httpsProxy: proxyUrl,
-        noProxy: noProxyValue,
+        httpProxy: 'http://proxy.example.com',
+        httpsProxy: 'http://proxy.example.com',
+        noProxy: 'localhost,127.0.0.1',
         headersTimeout: 45773134,
         bodyTimeout: 300000,
       });
@@ -270,4 +272,22 @@ describe('fetch utils', () => {
       );
     });
   });
+
+  describe('createSafeProxyAgent', () => {
+    it('should create an EnvHttpProxyAgent with trimmed values and default timeouts', () => {
+      const proxyUrl = ' http://proxy.example.com ';
+      const noProxyValue = ' localhost,127.0.0.1 ';
+      vi.stubEnv('NO_PROXY', noProxyValue);
+
+      createSafeProxyAgent(proxyUrl);
+
+      expect(EnvHttpProxyAgent).toHaveBeenCalledWith({
+        httpProxy: 'http://proxy.example.com',
+        httpsProxy: 'http://proxy.example.com',
+        noProxy: 'localhost,127.0.0.1',
+        headersTimeout: 60000,
+        bodyTimeout: 300000,
+      });
+    });
+  });
 });

packages/core/src/utils/fetch.ts

@@ -172,11 +172,14 @@ export async function isPrivateIpAsync(url: string): Promise<boolean> {
  * Creates an undici EnvHttpProxyAgent that incorporates safe DNS lookup.
  */
 export function createSafeProxyAgent(proxyUrl: string): EnvHttpProxyAgent {
-  const noProxy = process.env['NO_PROXY'] || process.env['no_proxy'];
+  const trimmedProxy = proxyUrl.trim();
+  const noProxy = (process.env['NO_PROXY'] || process.env['no_proxy'])?.trim();
   return new EnvHttpProxyAgent({
-    httpProxy: proxyUrl,
-    httpsProxy: proxyUrl,
+    httpProxy: trimmedProxy,
+    httpsProxy: trimmedProxy,
     noProxy,
+    headersTimeout: defaultHeadersTimeout,
+    bodyTimeout: defaultBodyTimeout,
   });
 }
 
@@ -223,12 +226,13 @@ export async function fetchWithTimeout(
 }
 
 export function setGlobalProxy(proxy: string) {
-  currentProxy = proxy;
-  const noProxy = process.env['NO_PROXY'] || process.env['no_proxy'];
+  const trimmedProxy = proxy.trim();
+  currentProxy = trimmedProxy;
+  const noProxy = (process.env['NO_PROXY'] || process.env['no_proxy'])?.trim();
   setGlobalDispatcher(
     new EnvHttpProxyAgent({
-      httpProxy: proxy,
-      httpsProxy: proxy,
+      httpProxy: trimmedProxy,
+      httpsProxy: trimmedProxy,
       noProxy,
       headersTimeout: defaultHeadersTimeout,
       bodyTimeout: defaultBodyTimeout,