Skip to content

Commit cc608b9

Browse files
fix(patch): cherry-pick ce56b4e to release/v0.16.0-preview.1-pr-13073 to patch version v0.16.0-preview.1 and create version 0.16.0-preview.2 (#13097)
Co-authored-by: Adib234 <30782825+Adib234@users.noreply.github.com>
1 parent ea4cd98 commit cc608b9

5 files changed

Lines changed: 15 additions & 16 deletions

File tree

packages/core/src/code_assist/experiments/experiments.test.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,8 @@ describe('experiments', () => {
4242
const { getExperiments } = await import('./experiments.js');
4343
const mockApiResponse: ListExperimentsResponse = {
4444
flags: [
45-
{ name: 'flag1', boolValue: true },
46-
{ name: 'flag2', stringValue: 'value' },
45+
{ flagId: 234, boolValue: true },
46+
{ flagId: 345, stringValue: 'value' },
4747
],
4848
experimentIds: [123, 456],
4949
};
@@ -58,12 +58,12 @@ describe('experiments', () => {
5858
);
5959

6060
// Verify that the response was parsed correctly
61-
expect(experiments.flags['flag1']).toEqual({
62-
name: 'flag1',
61+
expect(experiments.flags[234]).toEqual({
62+
flagId: 234,
6363
boolValue: true,
6464
});
65-
expect(experiments.flags['flag2']).toEqual({
66-
name: 'flag2',
65+
expect(experiments.flags[345]).toEqual({
66+
flagId: 345,
6767
stringValue: 'value',
6868
});
6969
expect(experiments.experimentIds).toEqual([123, 456]);
@@ -85,15 +85,15 @@ describe('experiments', () => {
8585
const mockApiResponse: ListExperimentsResponse = {
8686
flags: [
8787
{ boolValue: true } as Flag, // No name
88-
{ name: 'flag2', stringValue: 'value' },
88+
{ flagId: 256, stringValue: 'value' },
8989
],
9090
};
9191
vi.mocked(mockServer.listExperiments).mockResolvedValue(mockApiResponse);
9292

9393
const experiments = await getExperiments(mockServer);
9494

9595
expect(Object.keys(experiments.flags)).toHaveLength(1);
96-
expect(experiments.flags['flag2']).toBeDefined();
96+
expect(experiments.flags[256]).toBeDefined();
9797
expect(experiments.flags['undefined']).toBeUndefined();
9898
});
9999

packages/core/src/code_assist/experiments/experiments.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,8 @@ export async function getExperiments(
3838
function parseExperiments(response: ListExperimentsResponse): Experiments {
3939
const flags: Record<string, Flag> = {};
4040
for (const flag of response.flags ?? []) {
41-
if (flag.name) {
42-
flags[flag.name] = flag;
41+
if (flag.flagId) {
42+
flags[flag.flagId] = flag;
4343
}
4444
}
4545
return {

packages/core/src/code_assist/experiments/flagNames.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,8 @@
55
*/
66

77
export const ExperimentFlags = {
8-
CONTEXT_COMPRESSION_THRESHOLD:
9-
'GeminiCLIContextCompression__threshold_fraction',
10-
USER_CACHING: 'GcliUserCaching__user_caching',
8+
CONTEXT_COMPRESSION_THRESHOLD: 45740197,
9+
USER_CACHING: 45740198,
1110
} as const;
1211

1312
export type ExperimentFlagName =

packages/core/src/code_assist/experiments/types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ export interface ListExperimentsResponse {
1919
}
2020

2121
export interface Flag {
22-
name?: string;
22+
flagId?: number;
2323
boolValue?: boolean;
2424
floatValue?: number;
2525
intValue?: string; // int64

packages/core/src/config/config.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1425,8 +1425,8 @@ export class Config {
14251425
this.experiments = experiments;
14261426
const flagSummaries = Object.entries(experiments.flags ?? {})
14271427
.sort(([a], [b]) => a.localeCompare(b))
1428-
.map(([name, flag]) => {
1429-
const summary: Record<string, unknown> = { name };
1428+
.map(([flagId, flag]) => {
1429+
const summary: Record<string, unknown> = { flagId };
14301430
if (flag.boolValue !== undefined) {
14311431
summary['boolValue'] = flag.boolValue;
14321432
}

0 commit comments

Comments
 (0)