refactor: address review comments for local protocol

Author: adamfweidman

packages/core/src/agent/content-utils.test.ts

@@ -187,16 +187,14 @@ describe('contentPartsToGeminiParts', () => {
     ]);
   });
 
-  it('serializes unknown ContentPart variants', () => {
+  it('throws on unknown ContentPart variants', () => {
     // Force an unknown variant past the type system
     const content = [
       { type: 'custom_widget', payload: 123 },
     ] as unknown as ContentPart[];
-    const result = contentPartsToGeminiParts(content);
-    expect(result).toHaveLength(1);
-    expect(result[0]).toEqual({
-      text: JSON.stringify({ type: 'custom_widget', payload: 123 }),
-    });
+    expect(() => contentPartsToGeminiParts(content)).toThrow(
+      'Unhandled ContentPart type: {"type":"custom_widget","payload":123}',
+    );
   });
 });
 

packages/core/src/agent/content-utils.ts

@@ -92,10 +92,12 @@ export function contentPartsToGeminiParts(content: ContentPart[]): Part[] {
         // References are converted to text for the model
         result.push({ text: part.text });
         break;
-      default:
-        // Serialize unknown ContentPart variants instead of dropping them
-        result.push({ text: JSON.stringify(part) });
+      default: {
+        ((x: never) => {
+          throw new Error(`Unhandled ContentPart type: ${JSON.stringify(x)}`);
+        })(part);
         break;
+      }
     }
   }
   return result;

packages/core/src/agent/legacy-agent-session.test.ts

@@ -239,11 +239,10 @@ describe('LegacyAgentSession', () => {
       );
     });
 
-    it('throws for non-message payloads', async () => {
+    it('returns null streamId for non-message payloads', async () => {
       const session = new LegacyAgentSession(deps);
-      await expect(session.send({ update: { title: 'test' } })).rejects.toThrow(
-        'only supports message sends',
-      );
+      const result = await session.send({ update: { title: 'test' } });
+      expect(result.streamId).toBeNull();
     });
 
     it('throws if send is called while a stream is active', async () => {

packages/core/src/agent/legacy-agent-session.ts

@@ -105,12 +105,10 @@ export class LegacyAgentProtocol implements AgentProtocol {
     };
   }
 
-  async send(payload: AgentSend): Promise<{ streamId: string }> {
+  async send(payload: AgentSend): Promise<{ streamId: string | null }> {
     const message = 'message' in payload ? payload.message : undefined;
     if (!message) {
-      throw new Error(
-        'LegacyAgentSession.send() only supports message sends for the moment.',
-      );
+      return { streamId: null };
     }
 
     if (this._activeStreamId) {
@@ -166,6 +164,7 @@ export class LegacyAgentProtocol implements AgentProtocol {
       } else {
         this._emitErrorAndAgentEnd(err);
       }
+    } finally {
       this._clearActiveStream();
     }
   }
@@ -387,6 +386,7 @@ export class LegacyAgentProtocol implements AgentProtocol {
     const meta: Record<string, unknown> = {};
     if (err instanceof Error) {
       meta['errorName'] = err.constructor.name;
+      meta['stack'] = err.stack;
       if ('exitCode' in err && typeof err.exitCode === 'number') {
         meta['exitCode'] = err.exitCode;
       }