test(core): convert integration tests to unit test cases and integrate into existing files

Author: cocosheng-g

packages/core/src/ide/ide-connection-utils.test.ts

@@ -37,6 +37,12 @@ vi.mock('node:fs', async (importOriginal) => {
   };
 });
 vi.mock('node:os');
+vi.mock('undici', () => ({
+  EnvHttpProxyAgent: vi.fn(),
+  fetch: vi.fn(),
+  setGlobalDispatcher: vi.fn(),
+  Agent: vi.fn(),
+}));
 
 describe('ide-connection-utils', () => {
   beforeEach(() => {
@@ -698,12 +704,34 @@ describe('ide-connection-utils', () => {
   });
 
   describe('createProxyAwareFetch', () => {
-    it('should return a proxy-aware fetcher function', async () => {
-      const { createProxyAwareFetch } = await import(
-        './ide-connection-utils.js'
-      );
-      const fetcher = await createProxyAwareFetch('127.0.0.1');
+    it('should return a proxy-aware fetcher function that respects NO_PROXY and includes ideServerHost', async () => {
+      const { createProxyAwareFetch } =
+        await import('./ide-connection-utils.js');
+      const { EnvHttpProxyAgent } = await import('undici');
+      const ideServerHost = '127.0.0.1';
+      const existingNoProxy = 'google.com,example.com';
+      vi.stubEnv('NO_PROXY', existingNoProxy);
+
+      const fetcher = await createProxyAwareFetch(ideServerHost);
       expect(typeof fetcher).toBe('function');
+
+      expect(EnvHttpProxyAgent).toHaveBeenCalledWith({
+        noProxy: `${existingNoProxy},${ideServerHost}`,
+      });
+    });
+
+    it('should handle missing NO_PROXY when creating proxy-aware fetcher', async () => {
+      const { createProxyAwareFetch } =
+        await import('./ide-connection-utils.js');
+      const { EnvHttpProxyAgent } = await import('undici');
+      const ideServerHost = 'host.docker.internal';
+      vi.stubEnv('NO_PROXY', '');
+
+      await createProxyAwareFetch(ideServerHost);
+
+      expect(EnvHttpProxyAgent).toHaveBeenCalledWith({
+        noProxy: ideServerHost,
+      });
     });
   });
 });

packages/core/src/tools/mcp-client.test.ts

@@ -74,6 +74,12 @@ let MOCK_CONTEXT: McpContext = MOCK_CONTEXT_DEFAULT;
 vi.mock('@modelcontextprotocol/sdk/client/stdio.js');
 vi.mock('@modelcontextprotocol/sdk/client/index.js');
 vi.mock('@google/genai');
+vi.mock('undici', () => ({
+  EnvHttpProxyAgent: vi.fn(),
+  fetch: vi.fn(),
+  setGlobalDispatcher: vi.fn(),
+  Agent: vi.fn(),
+}));
 vi.mock('../mcp/oauth-provider.js');
 vi.mock('../mcp/oauth-token-storage.js');
 vi.mock('../mcp/oauth-utils.js');
@@ -1779,6 +1785,29 @@ describe('mcp-client', () => {
   });
 
   describe('createTransport', () => {
+    it('should create an HTTP transport that respects NO_PROXY', async () => {
+      const { createTransport } = await import('./mcp-client.js');
+      const { EnvHttpProxyAgent } = await import('undici');
+      const noProxyValue = 'localhost,127.0.0.1';
+      vi.stubEnv('NO_PROXY', noProxyValue);
+
+      await createTransport(
+        'test-server',
+        {
+          url: 'http://test-server',
+          type: 'http',
+        },
+        false,
+        MOCK_CONTEXT,
+      );
+
+      expect(EnvHttpProxyAgent).toHaveBeenCalledWith(
+        expect.objectContaining({
+          noProxy: noProxyValue,
+        }),
+      );
+    });
+
     describe('should connect via httpUrl', () => {
       it('uses MCP SDK authProvider token() path for oauth-enabled servers', async () => {
         const mockGetValidTokenWithMetadata = vi.fn().mockResolvedValue({

packages/core/src/utils/fetch.test.ts

@@ -271,6 +271,33 @@ describe('fetch utils', () => {
         }),
       );
     });
+
+    it('should handle empty NO_PROXY', () => {
+      const proxyUrl = 'http://proxy.example.com';
+      vi.stubEnv('NO_PROXY', '');
+
+      setGlobalProxy(proxyUrl);
+
+      expect(EnvHttpProxyAgent).toHaveBeenCalledWith(
+        expect.objectContaining({
+          noProxy: '',
+        }),
+      );
+    });
+
+    it('should handle multi-entry NO_PROXY with trimming', () => {
+      const proxyUrl = 'http://proxy.example.com';
+      const noProxyValue = '  google.com, 127.0.0.1 , localhost  ';
+      vi.stubEnv('NO_PROXY', noProxyValue);
+
+      setGlobalProxy(proxyUrl);
+
+      expect(EnvHttpProxyAgent).toHaveBeenCalledWith(
+        expect.objectContaining({
+          noProxy: 'google.com, 127.0.0.1 , localhost',
+        }),
+      );
+    });
   });
 
   describe('createSafeProxyAgent', () => {

packages/core/src/utils/fetch.ts

@@ -173,7 +173,11 @@ export async function isPrivateIpAsync(url: string): Promise<boolean> {
  */
 export function createSafeProxyAgent(proxyUrl: string): EnvHttpProxyAgent {
   const trimmedProxy = proxyUrl.trim();
-  const noProxy = (process.env['NO_PROXY'] || process.env['no_proxy'])?.trim();
+  const noProxy = (
+    process.env['NO_PROXY'] ??
+    process.env['no_proxy'] ??
+    ''
+  )?.trim();
   return new EnvHttpProxyAgent({
     httpProxy: trimmedProxy,
     httpsProxy: trimmedProxy,
@@ -228,7 +232,11 @@ export async function fetchWithTimeout(
 export function setGlobalProxy(proxy: string) {
   const trimmedProxy = proxy.trim();
   currentProxy = trimmedProxy;
-  const noProxy = (process.env['NO_PROXY'] || process.env['no_proxy'])?.trim();
+  const noProxy = (
+    process.env['NO_PROXY'] ??
+    process.env['no_proxy'] ??
+    ''
+  )?.trim();
   setGlobalDispatcher(
     new EnvHttpProxyAgent({
       httpProxy: trimmedProxy,