fix(patch): cherry-pick 467a305 to release/v0.9.0-preview.0-pr-10661 to patch version v0.9.0-preview.0 and create version 0.9.0-preview.1

[gemini-cli-robot]

This PR automatically cherry-picks commit 467a305 to patch version v0.9.0-preview.0 in the preview release to create version 0.9.0-preview.1.

[gemini-code-assist]

Summary of Changes

Hello @gemini-cli-robot, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request is an automated patch release, updating the preview version from v0.9.0-preview.0 to v0.9.0-preview.1. The core change involves a significant refactoring of the interactive shell configuration, standardizing the naming convention from shouldUseNodePtyShell to enableInteractiveShell. Crucially, this change also sets interactive shell functionality as the default behavior, aiming to enhance the out-of-the-box user experience by providing interactive terminal capabilities without requiring manual configuration.

Highlights

• Configuration Renaming: The configuration setting related to interactive shell functionality has been renamed from shouldUseNodePtyShell to enableInteractiveShell across the codebase for clarity and consistency.
• Default Interactive Shell: The default value for tools.shell.enableInteractiveShell has been changed from false to true, making interactive shell experiences enabled by default.
• Documentation Update: The documentation for the interactive shell setting (docs/get-started/configuration.md) has been updated to reflect the new default value and provide a clearer description.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[github-actions]

Size Change: +17 B (0%)

Total Size: 17.7 MB

ℹ️ View Unchanged

Filename	Size	Change
./bundle/gemini.js	17.7 MB	+17 B (0%)
./bundle/sandbox-macos-permissive-closed.sb	1.03 kB	0 B
./bundle/sandbox-macos-permissive-open.sb	830 B	0 B
./bundle/sandbox-macos-permissive-proxied.sb	1.31 kB	0 B
./bundle/sandbox-macos-restrictive-closed.sb	3.29 kB	0 B
./bundle/sandbox-macos-restrictive-open.sb	3.36 kB	0 B
./bundle/sandbox-macos-restrictive-proxied.sb	3.56 kB	0 B

_{compressed-size-action}

[gemini-code-assist]

Code Review

This pull request refactors the shouldUseNodePtyShell configuration to enableInteractiveShell and changes its default value to true. The changes are mostly correct, but I've found two issues. First, a critical issue in the settings migration map that breaks backward compatibility for users with the old setting. Second, a high-severity issue regarding an inconsistent default value for the new setting in the core Config class, which could lead to incorrect behavior. I've provided suggestions to fix both issues.

[gemini-code-assist]

This change breaks settings migration for users with the old shouldUseNodePtyShell setting. MIGRATION_MAP is used for migrating old settings to the new nested format (V1 to V2) and for determining the key name when saving back to the flat format (V2 to V1).

By replacing shouldUseNodePtyShell with enableInteractiveShell as the key, you've removed the logic that migrates existing user settings.

To support both migrating the old setting and using the new name when saving, both keys should be present in the map. The old key ensures migration, and the new key (as the last entry for this path) will be used by the reverse map for saving.

Suggested change

	enableInteractiveShell: 'tools.shell.enableInteractiveShell',
	shouldUseNodePtyShell: 'tools.shell.enableInteractiveShell',
	enableInteractiveShell: 'tools.shell.enableInteractiveShell',

[gemini-code-assist]

The default value for enableInteractiveShell is inconsistent across the codebase. Here in the Config constructor, it defaults to false (?? false), while the schema (packages/cli/src/config/settingsSchema.ts) and the CLI config loader (packages/cli/src/config/config.ts) now default to true. This could lead to unexpected behavior where the interactive shell is disabled when it should be enabled by default. To ensure consistency, the default value should be true here as well.

Suggested change

	this.enableInteractiveShell = params.enableInteractiveShell ?? false;
	this.enableInteractiveShell = params.enableInteractiveShell ?? true;