Skip to content

fix(patch): cherry-pick cce2457 to release/v0.8.1-pr-10856 to patch version v0.8.1 and create version 0.8.2#10859

Merged
chrstnb merged 1 commit into
release/v0.8.1-pr-10856from
hotfix/v0.8.1/0.8.2/stable/cherry-pick-cce2457/pr-10856
Oct 9, 2025
Merged

fix(patch): cherry-pick cce2457 to release/v0.8.1-pr-10856 to patch version v0.8.1 and create version 0.8.2#10859
chrstnb merged 1 commit into
release/v0.8.1-pr-10856from
hotfix/v0.8.1/0.8.2/stable/cherry-pick-cce2457/pr-10856

Conversation

@gemini-cli-robot

Copy link
Copy Markdown
Collaborator

This PR automatically cherry-picks commit cce2457 to patch version v0.8.1 in the stable release to create version 0.8.2.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @gemini-cli-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the stability of telemetry logging within the core package by introducing explicit error handling for asynchronous flush operations. The changes are part of an automated process to create a patch release, v0.8.2, ensuring that critical fixes or improvements are propagated to stable versions efficiently. The primary impact is improved resilience in data collection, preventing potential failures from disrupting user experience.

Highlights

  • Telemetry Error Handling: Implemented robust error handling for telemetry flushing operations by wrapping flushToClearcut() calls in try-catch blocks within various extension event logging methods. This ensures that any issues during data transmission are caught and logged without interrupting the application.
  • Automated Patch Release: This pull request is an automated cherry-pick of a specific commit (cce2457) to create a new patch version v0.8.2 from the v0.8.1 stable release branch.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly ensures that important extension-related telemetry events (install, uninstall, enable, disable) are flushed immediately, preventing data loss. However, this change introduces identical code blocks in four different methods. My review focuses on this duplication, suggesting a refactoring into a private helper method to improve code maintainability and adhere to the DRY principle.

Comment on lines +905 to +907
this.flushToClearcut().catch((error) => {
console.debug('Error flushing to Clearcut:', error);
});

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This logic to force-flush events and handle potential errors is duplicated across logExtensionInstallEvent, logExtensionUninstallEvent, logExtensionEnableEvent, and logExtensionDisableEvent in this PR. This pattern also exists in other methods within this class.

To improve maintainability and adhere to the DRY (Don't Repeat Yourself) principle, consider extracting this logic into a private helper method. For example:

private forceFlushAndForget(): void {
  this.flushToClearcut().catch((error) => {
    console.debug('Error flushing to Clearcut:', error);
  });
}

You could then replace the duplicated blocks with a call to this.forceFlushAndForget();.

@github-actions

github-actions Bot commented Oct 9, 2025

Copy link
Copy Markdown

Size Change: +378 B (0%)

Total Size: 17.6 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 17.6 MB +378 B (0%)
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB 0 B
./bundle/sandbox-macos-permissive-open.sb 830 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B

compressed-size-action

@chrstnb chrstnb merged commit 9b2d4c6 into release/v0.8.1-pr-10856 Oct 9, 2025
20 checks passed
@chrstnb chrstnb deleted the hotfix/v0.8.1/0.8.2/stable/cherry-pick-cce2457/pr-10856 branch October 9, 2025 23:57
@sripasg sripasg added the size/s A small PR label Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/s A small PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants