fix(patch): cherry-pick 0a7ee67 to release/v0.8.2-pr-10900 to patch version v0.8.2 and create version 0.8.3#11109
Conversation
Summary of ChangesHello @gemini-cli-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new patch version, Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request patches the screen reader accessibility feature by setting a default value and adding a notification. My review focuses on the notification message in Notifications.tsx. The current implementation provides incorrect and user-unfriendly instructions for disabling the screen reader mode. I've suggested an improved message that guides the user to an existing command, which is more robust and provides a better user experience.
| {isScreenReaderEnabled && ( | ||
| <Text> | ||
| You are currently in screen reader-friendly view. To switch out, open{' '} | ||
| {settingsPath} and remove the entry for {'"screenReader"'}. | ||
| </Text> | ||
| )} |
There was a problem hiding this comment.
This message has a few issues:
- Incorrect Path: It directs the user to a specific file (
~/.gemini/settings.json), but the setting could be active from a different file with higher precedence (like a project-level settings file), making the instruction incorrect. - Incorrect Key: The setting key is
ui.accessibility.screenReader, not justscreenReader. - Poor UX: Asking users to manually edit a JSON file is error-prone.
Since this setting has showInDialog: true, it would be much better to guide the user to the settings dialog. This change would also make the settingsPath constant and its related imports (path, homedir) unnecessary.
| {isScreenReaderEnabled && ( | |
| <Text> | |
| You are currently in screen reader-friendly view. To switch out, open{' '} | |
| {settingsPath} and remove the entry for {'"screenReader"'}. | |
| </Text> | |
| )} | |
| {isScreenReaderEnabled && ( | |
| <Text> | |
| You are currently in screen reader-friendly view. To switch out, use the | |
| `/settings` command to disable 'Screen Reader Mode'. | |
| </Text> | |
| )} |
|
Size Change: +538 B (0%) Total Size: 17.6 MB ℹ️ View Unchanged
|
This PR automatically cherry-picks commit 0a7ee67 to patch version v0.8.2 in the stable release to create version 0.8.3.