Skip to content

fix(patch): cherry-pick 0a7ee67 to release/v0.8.2-pr-10900 to patch version v0.8.2 and create version 0.8.3#11109

Closed
gemini-cli-robot wants to merge 1 commit into
release/v0.8.2-pr-10900from
hotfix/v0.8.2/0.8.3/stable/cherry-pick-0a7ee67/pr-10900
Closed

fix(patch): cherry-pick 0a7ee67 to release/v0.8.2-pr-10900 to patch version v0.8.2 and create version 0.8.3#11109
gemini-cli-robot wants to merge 1 commit into
release/v0.8.2-pr-10900from
hotfix/v0.8.2/0.8.3/stable/cherry-pick-0a7ee67/pr-10900

Conversation

@gemini-cli-robot

Copy link
Copy Markdown
Collaborator

This PR automatically cherry-picks commit 0a7ee67 to patch version v0.8.2 in the stable release to create version 0.8.3.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @gemini-cli-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new patch version, v0.8.3, by cherry-picking a critical commit. The primary purpose of this update is to enhance accessibility within the CLI by adding a dedicated screen reader mode. This mode provides a plaintext interactive view and includes user guidance within the application when it is active, ensuring a more inclusive user experience.

Highlights

  • Cherry-Pick for Patch Release: Commit 0a7ee67 has been cherry-picked to create patch version v0.8.3 from v0.8.2.
  • Screen Reader Accessibility Setting: A new configuration setting, ui.accessibility.screenReader, has been introduced to enable a plaintext interactive view for improved screen reader compatibility. Its default value is false.
  • In-App Screen Reader Notification: The CLI now displays a notification when screen reader mode is active, providing instructions on how to disable it by modifying the settings.json file.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request patches the screen reader accessibility feature by setting a default value and adding a notification. My review focuses on the notification message in Notifications.tsx. The current implementation provides incorrect and user-unfriendly instructions for disabling the screen reader mode. I've suggested an improved message that guides the user to an existing command, which is more robust and provides a better user experience.

Comment on lines +38 to +43
{isScreenReaderEnabled && (
<Text>
You are currently in screen reader-friendly view. To switch out, open{' '}
{settingsPath} and remove the entry for {'"screenReader"'}.
</Text>
)}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This message has a few issues:

  1. Incorrect Path: It directs the user to a specific file (~/.gemini/settings.json), but the setting could be active from a different file with higher precedence (like a project-level settings file), making the instruction incorrect.
  2. Incorrect Key: The setting key is ui.accessibility.screenReader, not just screenReader.
  3. Poor UX: Asking users to manually edit a JSON file is error-prone.

Since this setting has showInDialog: true, it would be much better to guide the user to the settings dialog. This change would also make the settingsPath constant and its related imports (path, homedir) unnecessary.

Suggested change
{isScreenReaderEnabled && (
<Text>
You are currently in screen reader-friendly view. To switch out, open{' '}
{settingsPath} and remove the entry for {'"screenReader"'}.
</Text>
)}
{isScreenReaderEnabled && (
<Text>
You are currently in screen reader-friendly view. To switch out, use the
`/settings` command to disable 'Screen Reader Mode'.
</Text>
)}

@github-actions

Copy link
Copy Markdown

Size Change: +538 B (0%)

Total Size: 17.6 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 17.6 MB +538 B (0%)
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB 0 B
./bundle/sandbox-macos-permissive-open.sb 830 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B

compressed-size-action

@chrstnb chrstnb closed this Oct 14, 2025
@chrstnb chrstnb deleted the hotfix/v0.8.2/0.8.3/stable/cherry-pick-0a7ee67/pr-10900 branch October 14, 2025 15:27
@sripasg sripasg added the size/s A small PR label Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/s A small PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants