Cherrypick #10900#11116
Conversation
Summary of ChangesHello @chrstnb, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances accessibility by introducing a new Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new ui.accessibility.screenReader setting. The changes include adding documentation, updating the settings schema, and adding a notification in the UI when this mode is active. My review focuses on a potential usability issue with the new notification message. I've identified a high-severity issue where a hardcoded file path in the notification could mislead users, and I've provided suggestions to make the message more robust and accurate.
| import { homedir } from 'node:os'; | ||
| import path from 'node:path'; | ||
|
|
||
| const settingsPath = path.join(homedir(), '.gemini', 'settings.json'); |
There was a problem hiding this comment.
This hardcoded path to the user settings file is problematic because the screenReader setting can be configured in multiple locations (e.g., project or system-level files). Instructing the user to edit this specific file can be misleading. As this constant and its imports will be unused with the suggested change to the notification message, these lines should be removed.
| {isScreenReaderEnabled && ( | ||
| <Text> | ||
| You are currently in screen reader-friendly view. To switch out, open{' '} | ||
| {settingsPath} and remove the entry for {'"screenReader"'}. | ||
| </Text> | ||
| )} |
There was a problem hiding this comment.
To avoid confusing users by pointing them to a potentially incorrect settings file, the notification message should be made more generic. Instead of a specific file path, it's better to refer to the setting name. Ideally, you could guide them to use the settings dialog, since showInDialog is enabled for this option.
| {isScreenReaderEnabled && ( | |
| <Text> | |
| You are currently in screen reader-friendly view. To switch out, open{' '} | |
| {settingsPath} and remove the entry for {'"screenReader"'}. | |
| </Text> | |
| )} | |
| {isScreenReaderEnabled && ( | |
| <Text> | |
| You are currently in screen reader-friendly view. To switch out, disable | |
| the 'ui.accessibility.screenReader' setting in your Gemini | |
| configuration. | |
| </Text> | |
| )} |
|
Size Change: +540 B (0%) Total Size: 17.7 MB ℹ️ View Unchanged
|
3 participants
TLDR
Dive Deeper
Reviewer Test Plan
Testing Matrix
Linked issues / bugs