fix(patch): cherry-pick 4d2a111 to release/v0.10.0-preview.0-pr-10866 to patch version v0.10.0-preview.0 and create version 0.10.0-preview.2#11412
Conversation
Summary of ChangesHello @skeshive, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request cherry-picks a fix to enable case-insensitive file searching within the CLI's Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request cherry-picks a fix for case-insensitive search in the @ completion feature, which correctly prevents redundant searches when only the casing of the input pattern changes. A corresponding test has been added to verify this behavior. However, I've noticed that a test related to the UI for long suggestions in reverse search has been skipped. While the main fix is sound, disabling tests is a concern for long-term maintainability and I've left a comment with a recommendation to address it.
| }); | ||
|
|
||
| it('expands and collapses long suggestion via Right/Left arrows', async () => { | ||
| it.skip('expands and collapses long suggestion via Right/Left arrows', async () => { |
There was a problem hiding this comment.
This test for expanding and collapsing long suggestions has been skipped. While this might be a temporary measure to unblock a release, it's important to address this. Skipping tests reduces coverage and can hide regressions in functionality. Please create a follow-up ticket to investigate why this test is failing and re-enable it as soon as possible. If the feature is no longer supported, the test and corresponding code should be removed.
|
Size Change: +26 B (0%) Total Size: 17.8 MB ℹ️ View Unchanged
|
This PR automatically cherry-picks commit 4d2a111 to patch version v0.10.0-preview.0 in the preview release to create version 0.10.0-preview.2.