Skip to content

fix(patch): cherry-pick 4d2a111 to release/v0.10.0-preview.0-pr-10866 to patch version v0.10.0-preview.0 and create version 0.10.0-preview.2#11412

Closed
skeshive wants to merge 1 commit into
release/v0.10.0-preview.0-pr-10866from
hotfix/v0.10.0-preview.0/0.10.0-preview.2/preview/cherry-pick-4d2a111/pr-10866
Closed

fix(patch): cherry-pick 4d2a111 to release/v0.10.0-preview.0-pr-10866 to patch version v0.10.0-preview.0 and create version 0.10.0-preview.2#11412
skeshive wants to merge 1 commit into
release/v0.10.0-preview.0-pr-10866from
hotfix/v0.10.0-preview.0/0.10.0-preview.2/preview/cherry-pick-4d2a111/pr-10866

Conversation

@skeshive

Copy link
Copy Markdown
Contributor

This PR automatically cherry-picks commit 4d2a111 to patch version v0.10.0-preview.0 in the preview release to create version 0.10.0-preview.2.

@skeshive skeshive requested a review from a team as a code owner October 17, 2025 20:28
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @skeshive, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request cherry-picks a fix to enable case-insensitive file searching within the CLI's @ completion mechanism. The core change involves normalizing the search pattern to lowercase, ensuring that file suggestions are found regardless of the casing used in the input. This improves the usability and robustness of the file completion feature.

Highlights

  • Case-Insensitive File Search: The @ completion feature now performs case-insensitive searches for files by converting the input pattern to lowercase before matching.
  • New Test Case: A new test has been added to useAtCompletion.test.ts to specifically verify the case-insensitive search functionality.
  • Test Skipped: An existing test in InputPrompt.test.tsx related to suggestion expansion/collapse has been temporarily skipped.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@skeshive skeshive closed this Oct 17, 2025

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request cherry-picks a fix for case-insensitive search in the @ completion feature, which correctly prevents redundant searches when only the casing of the input pattern changes. A corresponding test has been added to verify this behavior. However, I've noticed that a test related to the UI for long suggestions in reverse search has been skipped. While the main fix is sound, disabling tests is a concern for long-term maintainability and I've left a comment with a recommendation to address it.

});

it('expands and collapses long suggestion via Right/Left arrows', async () => {
it.skip('expands and collapses long suggestion via Right/Left arrows', async () => {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This test for expanding and collapsing long suggestions has been skipped. While this might be a temporary measure to unblock a release, it's important to address this. Skipping tests reduces coverage and can hide regressions in functionality. Please create a follow-up ticket to investigate why this test is failing and re-enable it as soon as possible. If the feature is no longer supported, the test and corresponding code should be removed.

@github-actions

Copy link
Copy Markdown

Size Change: +26 B (0%)

Total Size: 17.8 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 17.8 MB +26 B (0%)
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB 0 B
./bundle/sandbox-macos-permissive-open.sb 830 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B

compressed-size-action

@mattKorwel mattKorwel deleted the hotfix/v0.10.0-preview.0/0.10.0-preview.2/preview/cherry-pick-4d2a111/pr-10866 branch October 30, 2025 21:28
@sripasg sripasg added the size/s A small PR label Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/s A small PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants