Skip to content

fix(patch): cherry-pick 4d2a111 to release/v0.10.0-preview.0-pr-10866 to patch version v0.10.0-preview.0 and create version 0.10.0-preview.2 #11412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
skeshive wants to merge 1 commit into from
Closed

fix(patch): cherry-pick 4d2a111 to release/v0.10.0-preview.0-pr-10866 to patch version v0.10.0-preview.0 and create version 0.10.0-preview.2 #11412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/cli/src/ui/components/InputPrompt.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2006,7 +2006,7 @@ describe('InputPrompt', () => {
unmount();
});

it('expands and collapses long suggestion via Right/Left arrows', async () => {
it.skip('expands and collapses long suggestion via Right/Left arrows', async () => {

@gemini-code-assist gemini-code-assist Bot Oct 17, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This test for expanding and collapsing long suggestions has been skipped. While this might be a temporary measure to unblock a release, it's important to address this. Skipping tests reduces coverage and can hide regressions in functionality. Please create a follow-up ticket to investigate why this test is failing and re-enable it as soon as possible. If the feature is no longer supported, the test and corresponding code should be removed.

props.shellModeActive = false;
const longValue = 'l'.repeat(200);

Expand Down
33 changes: 33 additions & 0 deletions packages/cli/src/ui/hooks/useAtCompletion.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,39 @@ describe('useAtCompletion', () => {
'file.txt',
]);
});

it('should perform a case-insensitive search by lowercasing the pattern', async () => {
testRootDir = await createTmpDir({ 'cRaZycAsE.txt': '' });

const fileSearch = FileSearchFactory.create({
projectRoot: testRootDir,
ignoreDirs: [],
useGitignore: false,
useGeminiignore: false,
cache: false,
enableRecursiveFileSearch: true,
disableFuzzySearch: false,
});
await fileSearch.initialize();

vi.spyOn(FileSearchFactory, 'create').mockReturnValue(fileSearch);

const { result } = renderHook(() =>
useTestHarnessForAtCompletion(
true,
'CrAzYCaSe',
mockConfig,
testRootDir,
),
);

// The hook should find 'cRaZycAsE.txt' even though the pattern is 'CrAzYCaSe'.
await waitFor(() => {
expect(result.current.suggestions.map((s) => s.value)).toEqual([
'cRaZycAsE.txt',
]);
});
});
});

describe('UI State and Loading Behavior', () => {
Expand Down
4 changes: 2 additions & 2 deletions packages/cli/src/ui/hooks/useAtCompletion.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,9 +145,9 @@ export function useAtCompletion(props: UseAtCompletionProps): void {
} else if (
(state.status === AtCompletionStatus.READY ||
state.status === AtCompletionStatus.SEARCHING) &&
pattern !== state.pattern // Only search if the pattern has changed
pattern.toLowerCase() !== state.pattern // Only search if the pattern has changed
) {
dispatch({ type: 'SEARCH', payload: pattern });
dispatch({ type: 'SEARCH', payload: pattern.toLowerCase() });
}
}, [enabled, pattern, state.status, state.pattern]);

Expand Down