Skip to content

Disable Routing by default#11549

Merged
abhipatel12 merged 1 commit into
mainfrom
abhipatel12/disable-routing-default-2
Oct 21, 2025
Merged

Disable Routing by default#11549
abhipatel12 merged 1 commit into
mainfrom
abhipatel12/disable-routing-default-2

Conversation

@abhipatel12

Copy link
Copy Markdown
Contributor

TLDR

Disable Routing by default

Reviewer Test Plan

Make sure routing is not enabled at default (remove all settings from settings.json for routing and then start)

Testing Matrix

🍏 🪟 🐧
npm run
npx
Docker
Podman - -
Seatbelt - -

@abhipatel12 abhipatel12 requested a review from a team as a code owner October 21, 2025 02:05
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @abhipatel12, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request alters the application's default behavior by deactivating the experimental model routing feature. Previously, this feature was enabled by default, but with this change, it will now be off by default, requiring users to explicitly opt-in if they wish to utilize it. This modification aims to provide a more controlled and predictable initial experience for users, allowing them to enable advanced features as needed.

Highlights

  • Default Model Routing: The useModelRouter setting is now disabled by default, meaning model routing will not be active unless explicitly enabled in the settings.
  • Configuration Logic Update: The core configuration logic in config.ts has been updated to set useModelRouter to false if it's not specified in the user's settings.
  • Settings Schema Adjustment: The settingsSchema.ts file now reflects this change, declaring false as the default value for the useModelRouter property.
  • Unit Test Alignment: Corresponding unit tests in config.test.ts and settingsSchema.test.ts have been modified to assert the new default behavior, ensuring consistency.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly disables model routing by default. The changes consistently update the default value for useModelRouter to false across the configuration logic, settings schema, and associated tests. The modifications are straightforward, well-tested, and achieve the intended goal. I have no issues to report.

@github-actions

Copy link
Copy Markdown

Size Change: 0 B

Total Size: 20.1 MB

ℹ️ View Unchanged
Filename Size
./bundle/gemini.js 20.1 MB
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB
./bundle/sandbox-macos-permissive-open.sb 890 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB

compressed-size-action

@abhipatel12 abhipatel12 added this pull request to the merge queue Oct 21, 2025
Merged via the queue into main with commit 8aace3a Oct 21, 2025
20 checks passed
@abhipatel12 abhipatel12 deleted the abhipatel12/disable-routing-default-2 branch October 21, 2025 02:23
@abhipatel12

Copy link
Copy Markdown
Contributor Author

/patch preview

@github-actions

Copy link
Copy Markdown

Patch workflow dispatch failed!

There was an error dispatching the patch creation workflow.

🔍 Troubleshooting:

  • Check that the PR is properly merged
  • Verify workflow permissions
  • Review error logs in the workflow run

🔗 Debug Links:

cocosheng-g pushed a commit to cocosheng-g/gemini-cli that referenced this pull request Oct 21, 2025
@mattKorwel

Copy link
Copy Markdown
Collaborator

/patch preview

@github-actions

Copy link
Copy Markdown

Patch workflow(s) dispatched successfully!

📋 Details:

  • Channels: preview
  • Commit: 8aace3aff2720e73405eff715678fa4b68b4aea6
  • Workflows Created: 1

🔗 Track Progress:

abhipatel12 added a commit that referenced this pull request Oct 21, 2025
github-actions Bot pushed a commit that referenced this pull request Oct 21, 2025
# Conflicts:
#	packages/cli/src/config/config.test.ts
@github-actions

Copy link
Copy Markdown

🚀 Patch PR Created!

📋 Patch Details:

📝 Next Steps:

  1. ⚠️ Resolve conflicts in the hotfix PR first: #11595
  2. Test your changes after resolving conflicts
  3. Once merged, the patch release will automatically trigger
  4. You'll receive updates here when the release completes

🔗 Track Progress:

@github-actions

Copy link
Copy Markdown

🚀 Patch Release Started!

📋 Release Details:

  • Environment: prod
  • Channel: preview → publishing to npm tag preview
  • Version: v0.10.0-preview.2
  • Hotfix PR: Merged ✅
  • Release Branch: release/v0.10.0-preview.2-pr-11549

⏳ Status: The patch release is now running. You'll receive another update when it completes.

🔗 Track Progress:

@github-actions

Copy link
Copy Markdown

Patch Release Complete!

📦 Release Details:

🎉 Status: Your patch has been successfully released and published to npm!

📝 What's Available:

🔗 Links:

@sripasg sripasg added the size/s A small PR label Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/s A small PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants