Disable Routing by default#11549
Conversation
Summary of ChangesHello @abhipatel12, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request alters the application's default behavior by deactivating the experimental model routing feature. Previously, this feature was enabled by default, but with this change, it will now be off by default, requiring users to explicitly opt-in if they wish to utilize it. This modification aims to provide a more controlled and predictable initial experience for users, allowing them to enable advanced features as needed. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly disables model routing by default. The changes consistently update the default value for useModelRouter to false across the configuration logic, settings schema, and associated tests. The modifications are straightforward, well-tested, and achieve the intended goal. I have no issues to report.
|
Size Change: 0 B Total Size: 20.1 MB ℹ️ View Unchanged
|
|
/patch preview |
|
❌ Patch workflow dispatch failed! There was an error dispatching the patch creation workflow. 🔍 Troubleshooting:
🔗 Debug Links: |
|
/patch preview |
|
✅ Patch workflow(s) dispatched successfully! 📋 Details:
🔗 Track Progress: |
This reverts commit 8aace3a.
# Conflicts: # packages/cli/src/config/config.test.ts
|
🚀 Patch PR Created! 📋 Patch Details:
📝 Next Steps:
🔗 Track Progress: |
|
🚀 Patch Release Started! 📋 Release Details:
⏳ Status: The patch release is now running. You'll receive another update when it completes. 🔗 Track Progress: |
|
✅ Patch Release Complete! 📦 Release Details:
🎉 Status: Your patch has been successfully released and published to npm! 📝 What's Available:
🔗 Links: |
TLDR
Disable Routing by default
Reviewer Test Plan
Make sure routing is not enabled at default (remove all settings from settings.json for routing and then start)
Testing Matrix