Only show screen reader notice once

[chrstnb]

Summary

Details

Related Issues

How to Validate

Pre-Merge Checklist

• Updated relevant documentation and README (if needed)
• Added/updated tests (if needed)
• Noted breaking changes (if any)
• Validated on required platforms/methods:
  • MacOS
    • npm run
    • npx
    • Docker
    • Podman
    • Seatbelt
  • Windows
    • npm run
    • npx
    • Docker
  • Linux
    • npm run
    • npx
    • Docker

[gemini-code-assist]

Summary of Changes

Hello @chrstnb, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the user experience for individuals using screen readers by ensuring that the informational notice about the screen reader-friendly view is presented only once per session. This prevents repetitive notifications and streamlines the initial interaction for accessibility users, making the application less intrusive while still providing crucial information.

Highlights

• New Setting for Screen Reader Nudge: A new boolean setting, "hasSeenScreenReaderNudge", has been introduced within the "ui.accessibility" configuration. This setting tracks whether the screen reader notice has been displayed to the user, defaults to "false", and is not exposed in the settings dialog.
• One-Time Screen Reader Notice Display: The "Notifications" component has been modified to ensure the screen reader-friendly view notice is displayed only once per user session. An "useEffect" hook is now utilized to update the "hasSeenScreenReaderNudge" setting to "true" immediately after the notice is shown.
• Updated Notice Text: The text of the screen reader notice has been updated to clarify its temporary nature, informing the user that the message will "disappear on re-start".

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[github-actions]

Size Change: +1.3 kB (+0.01%)

Total Size: 20.4 MB

Filename	Size	Change
./bundle/gemini.js	20.4 MB	+1.3 kB (+0.01%)

ℹ️ View Unchanged

Filename	Size
./bundle/sandbox-macos-permissive-closed.sb	1.03 kB
./bundle/sandbox-macos-permissive-open.sb	890 B
./bundle/sandbox-macos-permissive-proxied.sb	1.31 kB
./bundle/sandbox-macos-restrictive-closed.sb	3.29 kB
./bundle/sandbox-macos-restrictive-open.sb	3.36 kB
./bundle/sandbox-macos-restrictive-proxied.sb	3.56 kB

_{compressed-size-action}

[gemini-code-assist]

Code Review

This pull request introduces a mechanism to show the screen reader accessibility notice only once. A new setting hasSeenScreenReaderNudge is added to track if the user has seen the notice. The Notifications component is updated to use this setting to control the visibility of the notice and to update the setting after the notice is shown.

My review has identified a couple of issues. First, there's a functional bug in how the setting is updated, which prevents the notice from disappearing immediately after being shown. I've suggested a fix to ensure the UI updates correctly. Second, the text of the notification has become misleading with the new logic, and I've proposed a clearer alternative.

[jacob314]

please add a test before landing so this doesn't regress.

[chrstnb]

/patch preview

[github-actions]

✅ Patch workflow(s) dispatched successfully!

📋 Details:

• Channels: preview
• Commit: fc42c4613f05d9ffc17fa403d0b8e87737f2269d
• Workflows Created: 1

🔗 Track Progress:

• View patch workflows
• This workflow run

[github-actions]

🚀 Patch PR Created!

📋 Patch Details:

• Channel: preview → will publish to npm tag preview
• Commit: fc42c4613f05d9ffc17fa403d0b8e87737f2269d
• Hotfix Branch: hotfix/v0.12.0-preview.9/0.12.0-preview.10/preview/cherry-pick-fc42c46/pr-12247
• Hotfix PR: #12533

📝 Next Steps:

1. Review and approve the hotfix PR: #12533
2. Once merged, the patch release will automatically trigger
3. You'll receive updates here when the release completes

🔗 Track Progress:

• View hotfix PR #12533