Skip to content

fix(patch): cherry-pick 82c1042 to release/v0.12.0-preview.0-pr-12231 to patch version v0.12.0-preview.0 and create version 0.12.0-preview.1#12262

Merged
scidomino merged 1 commit into
release/v0.12.0-preview.0-pr-12231from
hotfix/v0.12.0-preview.0/0.12.0-preview.1/preview/cherry-pick-82c1042/pr-12231
Oct 29, 2025
Merged

fix(patch): cherry-pick 82c1042 to release/v0.12.0-preview.0-pr-12231 to patch version v0.12.0-preview.0 and create version 0.12.0-preview.1#12262
scidomino merged 1 commit into
release/v0.12.0-preview.0-pr-12231from
hotfix/v0.12.0-preview.0/0.12.0-preview.1/preview/cherry-pick-82c1042/pr-12231

Conversation

@gemini-cli-robot

Copy link
Copy Markdown
Collaborator

This PR automatically cherry-picks commit 82c1042 to patch version v0.12.0-preview.0 in the preview release to create version 0.12.0-preview.1.

@gemini-cli-robot gemini-cli-robot requested a review from a team as a code owner October 29, 2025 21:43
@github-actions github-actions Bot mentioned this pull request Oct 29, 2025
18 tasks
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @gemini-cli-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the handling of Alt (Meta) key combinations for macOS users within the CLI. It specifically targets and remaps certain Alt key outputs (like "∫" for Alt+b) to their intended base characters, ensuring consistent functionality for actions such as moving words or toggling markup views. The change includes updated documentation and dedicated tests to confirm the correct behavior across various macOS terminal environments.

Highlights

  • Refined macOS Alt Key Handling: The CLI's keypress context now specifically remaps Alt+b, Alt+f, and Alt+m (which produce "∫", "ƒ", "µ" on macOS) to their base characters, ensuring consistent functionality for actions like moving words or toggling views.
  • Platform-Specific Remapping: The Alt key remapping logic has been updated to explicitly apply only when the application is running on macOS (process.platform === 'darwin'), preventing unintended behavior on other operating systems.
  • Updated Documentation: The keyboard-shortcuts.md file has been updated to include a new section detailing these specific Meta+key combinations and their functionality on Mac, improving user understanding.
  • Enhanced Testing: New tests have been added to verify the cross-terminal Alt key handling specifically for macOS, ensuring correct behavior for Alt+b, Alt+f, and Alt+m across different terminal emulators like iTerm2, Ghostty, MacTerminal, and VSCodeTerminal.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request cherry-picks a fix for handling Meta+key combinations on macOS. The changes correctly limit the special character remapping logic to the 'darwin' platform and scope it to only the necessary key mappings (b, f, m). The accompanying test changes properly mock the platform to ensure the new logic is covered, and the documentation is updated to reflect this Mac-specific behavior. The changes are well-implemented and improve the robustness of keyboard input handling. I have no further suggestions.

@github-actions

Copy link
Copy Markdown

Size Change: -251 B (0%)

Total Size: 20.2 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 20.2 MB -251 B (0%)
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B

compressed-size-action

@scidomino scidomino merged commit daced0e into release/v0.12.0-preview.0-pr-12231 Oct 29, 2025
20 of 21 checks passed
@scidomino scidomino deleted the hotfix/v0.12.0-preview.0/0.12.0-preview.1/preview/cherry-pick-82c1042/pr-12231 branch October 29, 2025 21:52
@sripasg sripasg added the size/m A medium sized PR label Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/m A medium sized PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants