fix(core): Add rootDir to tsconfig.json to resolve TS5055 error#12274
Conversation
Summary of ChangesHello @mattKorwel, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical build failure in the release CI pipeline. The issue stemmed from an ambiguity in the TypeScript configuration for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses a TypeScript build failure (TS5055) by adding "rootDir": "." to the tsconfig.json for the @google/gemini-cli-core package. The change is correct and directly resolves the ambiguity in the project structure that caused the build error, which arises from having source files at both the package root and within the src directory. The fix is appropriate and I see no issues with it.
|
Size Change: -2 B (0%) Total Size: 20.3 MB ℹ️ View Unchanged
|
…hs and move husky to postinstall
|
/patch preview |
|
✅ Patch workflow(s) dispatched successfully! 📋 Details:
🔗 Track Progress: |
|
🚀 Patch PR Created! 📋 Patch Details:
📝 Next Steps:
🔗 Track Progress: |
|
🚀 Patch Release Started! 📋 Release Details:
⏳ Status: The patch release is now running. You'll receive another update when it completes. 🔗 Track Progress: |
|
❌ Patch Release Failed! 📋 Details:
🔍 Next Steps:
🔗 Troubleshooting: |
2 similar comments
|
❌ Patch Release Failed! 📋 Details:
🔍 Next Steps:
🔗 Troubleshooting: |
|
❌ Patch Release Failed! 📋 Details:
🔍 Next Steps:
🔗 Troubleshooting: |
…solve TS5055 error (google-gemini#12274)
2 participants
This change fixes a build failure that was occurring in the release CI pipeline.
The build was failing with the error:
TS5055: Cannot write file ... because it would overwrite input file.This error was caused by an ambiguity in the TypeScript configuration for the
@google/gemini-cli-corepackage. Theindex.tsfile at the package root re-exports symbols fromsrc/index.ts, which confuses the TypeScript compiler when it tries to determine the project's file structure for generating declaration files.This change resolves the issue by adding
\rootDir\: \.\to thecompilerOptionsinpackages/core/tsconfig.json. This explicitly tells the compiler to treat the entire package directory as the source root, removing the ambiguity and allowing the build to complete successfully. It also changes the globbing includes to limit it expliclity to the SRC dir. This was the actual fix.Pre change repo steps
After fix
Repeat above steps with no errors.