fix(patch): cherry-pick 42c79c6 to release/v0.12.0-preview.0-pr-12274 to patch version v0.12.0-preview.0 and create version 0.12.0-preview.1#12283
Conversation
Summary of ChangesHello @gemini-cli-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on maintenance and build process improvements, specifically by cherry-picking a commit to create a new patch version for a preview release. It refines the project's Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request, an automatic cherry-pick, introduces two main changes. First, it refactors the npm scripts in package.json by moving the husky setup from the prepare script to a postinstall script. This is a good improvement that ensures git hooks are installed correctly, especially when using npm ci. Second, it updates the tsconfig.json for the @google/gemini-cli-core package to refine file inclusion/exclusion and set the rootDir. While the tsconfig.json changes are logical, they introduce a critical issue. A custom linter in scripts/lint.js restricts the exclude property to specific values, and the new values added in this PR will cause the linting step to fail. This suggests an incomplete cherry-pick, as the linter script was not updated accordingly.
| "include": ["index.ts", "src/**/*.ts", "src/**/*.json"], | ||
| "exclude": ["node_modules", "dist"] | ||
| "include": ["index.ts", "src"], | ||
| "exclude": ["node_modules", "dist", "**/*.snap", "**/*.wasm"] |
There was a problem hiding this comment.
While adding "**/*.snap" and "**/*.wasm" to the exclude array is correct given the project structure, it will cause a build failure. There is a custom linter in scripts/lint.js (runTSConfigLinter) that strictly validates the contents of the exclude array in tsconfig.json files. Currently, it only permits "node_modules" and "dist".
This change will cause the linter to fail, breaking the CI pipeline. This appears to be an incomplete cherry-pick, as the linter script itself should have been updated to allow these new exclusion patterns.
|
Size Change: -2 B (0%) Total Size: 20.2 MB ℹ️ View Unchanged
|
1a58888
into
release/v0.12.0-preview.0-pr-12274
This PR automatically cherry-picks commit 42c79c6 to patch version v0.12.0-preview.0 in the preview release to create version 0.12.0-preview.1.