Skip to content

fix(patch): cherry-pick 42c79c6 to release/v0.12.0-preview.0-pr-12274 to patch version v0.12.0-preview.0 and create version 0.12.0-preview.1#12283

Merged
mattKorwel merged 1 commit into
release/v0.12.0-preview.0-pr-12274from
hotfix/v0.12.0-preview.0/0.12.0-preview.1/preview/cherry-pick-42c79c6/pr-12274
Oct 30, 2025
Merged

fix(patch): cherry-pick 42c79c6 to release/v0.12.0-preview.0-pr-12274 to patch version v0.12.0-preview.0 and create version 0.12.0-preview.1#12283
mattKorwel merged 1 commit into
release/v0.12.0-preview.0-pr-12274from
hotfix/v0.12.0-preview.0/0.12.0-preview.1/preview/cherry-pick-42c79c6/pr-12274

Conversation

@gemini-cli-robot

Copy link
Copy Markdown
Collaborator

This PR automatically cherry-picks commit 42c79c6 to patch version v0.12.0-preview.0 in the preview release to create version 0.12.0-preview.1.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @gemini-cli-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on maintenance and build process improvements, specifically by cherry-picking a commit to create a new patch version for a preview release. It refines the project's package.json to optimize the husky setup for Git hooks and modifies the tsconfig.json for the core package to enhance TypeScript compilation configurations.

Highlights

  • Build Script Update: The package.json file has been updated to move the husky initialization from the prepare script to a new postinstall script, ensuring husky hooks are installed after package installation.
  • TypeScript Configuration Refinement: The tsconfig.json for the core package now includes rootDir: ".", simplifies the include paths, and expands the exclude list to ignore snapshot and WebAssembly files, optimizing TypeScript compilation settings.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@mattKorwel mattKorwel enabled auto-merge (squash) October 30, 2025 06:27

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, an automatic cherry-pick, introduces two main changes. First, it refactors the npm scripts in package.json by moving the husky setup from the prepare script to a postinstall script. This is a good improvement that ensures git hooks are installed correctly, especially when using npm ci. Second, it updates the tsconfig.json for the @google/gemini-cli-core package to refine file inclusion/exclusion and set the rootDir. While the tsconfig.json changes are logical, they introduce a critical issue. A custom linter in scripts/lint.js restricts the exclude property to specific values, and the new values added in this PR will cause the linting step to fail. This suggests an incomplete cherry-pick, as the linter script was not updated accordingly.

"include": ["index.ts", "src/**/*.ts", "src/**/*.json"],
"exclude": ["node_modules", "dist"]
"include": ["index.ts", "src"],
"exclude": ["node_modules", "dist", "**/*.snap", "**/*.wasm"]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

While adding "**/*.snap" and "**/*.wasm" to the exclude array is correct given the project structure, it will cause a build failure. There is a custom linter in scripts/lint.js (runTSConfigLinter) that strictly validates the contents of the exclude array in tsconfig.json files. Currently, it only permits "node_modules" and "dist".

This change will cause the linter to fail, breaking the CI pipeline. This appears to be an incomplete cherry-pick, as the linter script itself should have been updated to allow these new exclusion patterns.

@github-actions

Copy link
Copy Markdown

Size Change: -2 B (0%)

Total Size: 20.2 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 20.2 MB -2 B (0%)
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B

compressed-size-action

@mattKorwel mattKorwel merged commit 1a58888 into release/v0.12.0-preview.0-pr-12274 Oct 30, 2025
21 checks passed
@mattKorwel mattKorwel deleted the hotfix/v0.12.0-preview.0/0.12.0-preview.1/preview/cherry-pick-42c79c6/pr-12274 branch October 30, 2025 06:34
@sripasg sripasg added the size/xs An extra small PR label Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xs An extra small PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants