Skip to content

fix(patch): cherry-pick 42c79c6 to release/v0.12.0-preview.0-pr-12274 to patch version v0.12.0-preview.0 and create version 0.12.0-preview.1 #12283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattKorwel merged 1 commit into from
Oct 30, 2025
Merged

fix(patch): cherry-pick 42c79c6 to release/v0.12.0-preview.0-pr-12274 to patch version v0.12.0-preview.0 and create version 0.12.0-preview.1 #12283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,8 @@
"format": "prettier --experimental-cli --write .",
"typecheck": "npm run typecheck --workspaces --if-present",
"preflight": "npm run clean && npm ci && npm run format && npm run lint:ci && npm run build && npm run typecheck && npm run test:ci",
"prepare": "husky && npm run bundle",
"postinstall": "husky",
"prepare": "npm run bundle",
"prepare:package": "node scripts/prepare-package.js",
"release:version": "node scripts/version.js",
"telemetry": "node scripts/telemetry.js",
Expand Down
5 changes: 3 additions & 2 deletions packages/core/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,9 @@
"outDir": "dist",
"lib": ["DOM", "DOM.Iterable", "ES2023"],
"composite": true,
"rootDir": ".",
"types": ["node", "vitest/globals"]
},
"include": ["index.ts", "src/**/*.ts", "src/**/*.json"],
"exclude": ["node_modules", "dist"]
"include": ["index.ts", "src"],
"exclude": ["node_modules", "dist", "**/*.snap", "**/*.wasm"]

@gemini-code-assist gemini-code-assist Bot Oct 30, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

While adding "**/*.snap" and "**/*.wasm" to the exclude array is correct given the project structure, it will cause a build failure. There is a custom linter in scripts/lint.js (runTSConfigLinter) that strictly validates the contents of the exclude array in tsconfig.json files. Currently, it only permits "node_modules" and "dist".

This change will cause the linter to fail, breaking the CI pipeline. This appears to be an incomplete cherry-pick, as the linter script itself should have been updated to allow these new exclusion patterns.

}