Revert "fix(core): Add rootDir to tsconfig.json to resolve TS5055 error"

[mattKorwel]

Reverts #12274

[gemini-code-assist]

Summary of Changes

Hello @mattKorwel, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request reverts a previous change that added 'rootDir' to the 'tsconfig.json' in the 'core' package, which was originally intended to fix a 'TS5055' error. Beyond undoing this specific configuration, it refines the TypeScript 'include' and 'exclude' patterns for better file management and adjusts the 'husky' hook installation process within the 'package.json' scripts. The overall aim is to streamline the build configuration and potentially address unintended side effects of the original 'rootDir' modification.

Highlights

• TypeScript Configuration Revert: The primary change is the removal of the 'rootDir: "."' setting from 'packages/core/tsconfig.json', which was previously introduced to resolve a TS5055 error.
• Refined TypeScript Include Paths: The 'include' array in 'packages/core/tsconfig.json' has been updated to explicitly specify 'src//*.ts' and 'src//*.json', providing more precise control over which files are included in the compilation.
• Simplified TypeScript Exclude Paths: The 'exclude' array in 'packages/core/tsconfig.json' has been streamlined by removing '/*.snap' and '/*.wasm', potentially altering the set of files ignored during TypeScript compilation.
• Husky Script Relocation: The 'husky' initialization command has been moved from the 'postinstall' script to be part of the 'prepare' script in 'package.json', ensuring it runs alongside the 'bundle' command.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request reverts a previous change, affecting package.json and packages/core/tsconfig.json. The changes appear to be beneficial. Moving the husky setup from the postinstall script to the prepare script in package.json aligns with recommended practices for setting up Git hooks. The modifications to packages/core/tsconfig.json result in a more explicit and clearer configuration. Specifically, the include paths are now more specific, which is an improvement in readability and maintainability. The removal of rootDir is acceptable, as TypeScript should correctly infer it from the specified include paths. Overall, the state of the code after this revert seems correct and well-structured.