Skip to content

fix(patch): cherry-pick 82c1042 to release/v0.12.0-preview.2-pr-12231 to patch version v0.12.0-preview.2 and create version 0.12.0-preview.3#12320

Merged
mattKorwel merged 1 commit into
release/v0.12.0-preview.2-pr-12231from
hotfix/v0.12.0-preview.2/0.12.0-preview.3/preview/cherry-pick-82c1042/pr-12231
Oct 30, 2025
Merged

fix(patch): cherry-pick 82c1042 to release/v0.12.0-preview.2-pr-12231 to patch version v0.12.0-preview.2 and create version 0.12.0-preview.3#12320
mattKorwel merged 1 commit into
release/v0.12.0-preview.2-pr-12231from
hotfix/v0.12.0-preview.2/0.12.0-preview.3/preview/cherry-pick-82c1042/pr-12231

Conversation

@gemini-cli-robot

Copy link
Copy Markdown
Collaborator

This PR automatically cherry-picks commit 82c1042 to patch version v0.12.0-preview.2 in the preview release to create version 0.12.0-preview.3.

@github-actions github-actions Bot mentioned this pull request Oct 30, 2025
18 tasks
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @gemini-cli-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a targeted fix for how specific Alt-key combinations are processed on macOS within the CLI. It refines the input handling to correctly interpret Alt+b, Alt+f, and Alt+m as their intended actions, such as navigating words or toggling markup, by mapping the unique characters produced by these keypresses on Mac. This change ensures consistent and expected keyboard shortcut behavior for macOS users, accompanied by updated documentation and dedicated test cases.

Highlights

  • Refined macOS Alt-key Handling: Specific Alt key combinations (Alt+b, Alt+f, Alt+m) on macOS are now correctly interpreted as their intended actions (back word, forward word, toggle markup view) by remapping their special character outputs (∫, ƒ, µ).
  • Platform-Specific Remapping: The Alt-key character remapping logic is now explicitly applied only when running on macOS (process.platform === 'darwin'), preventing unintended behavior on other operating systems.
  • Updated Documentation: The keyboard-shortcuts.md file has been updated to include a new section detailing the Meta+key (Alt-key on Mac) combos and their special functionalities.
  • Improved Test Coverage: Tests for cross-terminal Alt-key handling have been enhanced and now explicitly simulate a macOS environment to ensure the correct behavior of the remapping logic.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request cherry-picks a fix for handling Alt+key combinations on macOS terminals. The changes are well-implemented and improve the existing logic. The large, generic ALT_KEY_CHARACTER_MAP has been correctly replaced with a smaller, more specific MAC_ALT_KEY_CHARACTER_MAP that only includes mappings for shortcuts used by the CLI. The logic is now correctly scoped to run only on darwin platforms. The accompanying test changes are also excellent, mocking process.platform to ensure the tests are reliable and specific to the macOS behavior. The documentation has also been updated to reflect these changes. Overall, this is a solid fix and I have no further recommendations.

@github-actions

Copy link
Copy Markdown

Size Change: -251 B (0%)

Total Size: 20.2 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 20.2 MB -251 B (0%)
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B

compressed-size-action

@mattKorwel mattKorwel enabled auto-merge (squash) October 30, 2025 22:24
@mattKorwel mattKorwel merged commit 3876379 into release/v0.12.0-preview.2-pr-12231 Oct 30, 2025
21 checks passed
@mattKorwel mattKorwel deleted the hotfix/v0.12.0-preview.2/0.12.0-preview.3/preview/cherry-pick-82c1042/pr-12231 branch October 30, 2025 22:28
@sripasg sripasg added the size/m A medium sized PR label Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/m A medium sized PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants