fix(patch): cherry-pick 82c1042 to release/v0.12.0-preview.2-pr-12231 to patch version v0.12.0-preview.2 and create version 0.12.0-preview.3#12320
Conversation
Summary of ChangesHello @gemini-cli-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a targeted fix for how specific Alt-key combinations are processed on macOS within the CLI. It refines the input handling to correctly interpret Alt+b, Alt+f, and Alt+m as their intended actions, such as navigating words or toggling markup, by mapping the unique characters produced by these keypresses on Mac. This change ensures consistent and expected keyboard shortcut behavior for macOS users, accompanied by updated documentation and dedicated test cases. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request cherry-picks a fix for handling Alt+key combinations on macOS terminals. The changes are well-implemented and improve the existing logic. The large, generic ALT_KEY_CHARACTER_MAP has been correctly replaced with a smaller, more specific MAC_ALT_KEY_CHARACTER_MAP that only includes mappings for shortcuts used by the CLI. The logic is now correctly scoped to run only on darwin platforms. The accompanying test changes are also excellent, mocking process.platform to ensure the tests are reliable and specific to the macOS behavior. The documentation has also been updated to reflect these changes. Overall, this is a solid fix and I have no further recommendations.
|
Size Change: -251 B (0%) Total Size: 20.2 MB ℹ️ View Unchanged
|
3876379
into
release/v0.12.0-preview.2-pr-12231
This PR automatically cherry-picks commit 82c1042 to patch version v0.12.0-preview.2 in the preview release to create version 0.12.0-preview.3.