fix(patch): cherry-pick 135d981 to release/v0.12.0-preview.6-pr-12299 to patch version v0.12.0-preview.6 and create version 0.12.0-preview.7#12368
Conversation
Summary of ChangesHello @gemini-cli-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request is an automated cherry-pick designed to create a new patch version. Its core purpose is to enhance the granularity and clarity of telemetry data by separating line change metrics from tool call latency, introducing a dedicated counter for tracking lines added and removed during tool operations. This change improves the precision of collected data without altering the functional behavior of the tool. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Size Change: +800 B (0%) Total Size: 20.2 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Code Review
This pull request refactors how line change telemetry is recorded, moving from attributes on the tool.call.count metric to a new dedicated gemini_cli.lines.changed counter.
While this is a good structural improvement, the current implementation has lost the ability to distinguish between model-generated and user-modified line changes, and it no longer records user-initiated changes at all. My review includes suggestions to reintroduce tracking for user-modified lines and to add a source attribute to the new metric to differentiate between model and user changes. This will restore the lost telemetry data and provide more granular insights. The corresponding tests will need to be updated to reflect these suggested changes.
9fbea50
into
release/v0.12.0-preview.6-pr-12299
This PR automatically cherry-picks commit 135d981 to patch version v0.12.0-preview.6 in the preview release to create version 0.12.0-preview.7.