Skip to content

fix(patch): cherry-pick 135d981 to release/v0.12.0-preview.6-pr-12299 to patch version v0.12.0-preview.6 and create version 0.12.0-preview.7#12368

Merged
jerop merged 1 commit into
release/v0.12.0-preview.6-pr-12299from
hotfix/v0.12.0-preview.6/0.12.0-preview.7/preview/cherry-pick-135d981/pr-12299
Oct 31, 2025
Merged

fix(patch): cherry-pick 135d981 to release/v0.12.0-preview.6-pr-12299 to patch version v0.12.0-preview.6 and create version 0.12.0-preview.7#12368
jerop merged 1 commit into
release/v0.12.0-preview.6-pr-12299from
hotfix/v0.12.0-preview.6/0.12.0-preview.7/preview/cherry-pick-135d981/pr-12299

Conversation

@gemini-cli-robot

Copy link
Copy Markdown
Collaborator

This PR automatically cherry-picks commit 135d981 to patch version v0.12.0-preview.6 in the preview release to create version 0.12.0-preview.7.

@gemini-cli-robot gemini-cli-robot requested a review from a team as a code owner October 31, 2025 14:11
@github-actions github-actions Bot mentioned this pull request Oct 31, 2025
18 tasks
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @gemini-cli-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request is an automated cherry-pick designed to create a new patch version. Its core purpose is to enhance the granularity and clarity of telemetry data by separating line change metrics from tool call latency, introducing a dedicated counter for tracking lines added and removed during tool operations. This change improves the precision of collected data without altering the functional behavior of the tool.

Highlights

  • Telemetry Refinement: The pull request refactors how line change metrics are collected for tool calls, moving them from attributes of the gemini_cli.tool.call.latency metric to a new, dedicated counter.
  • New Metric Introduced: A new telemetry counter, gemini_cli.lines.changed, has been added to specifically track the number of lines added or removed during tool operations, along with the function name and change type.
  • Documentation Update: The docs/cli/telemetry.md file has been updated to reflect the removal of line change attributes from gemini_cli.tool.call.latency and the addition of the new gemini_cli.lines.changed metric.
  • Code Implementation: The logToolCall function in packages/core/src/telemetry/loggers.ts now utilizes the new recordLinesChanged function to log line changes separately, rather than as part of the tool call latency metric.
  • Testing Updates: Corresponding test files (loggers.test.ts and metrics.test.ts) have been updated to include mocks and assertions for the new recordLinesChanged metric and its integration.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions

Copy link
Copy Markdown

Size Change: +800 B (0%)

Total Size: 20.2 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 20.2 MB +800 B (0%)
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B

compressed-size-action

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors how line change telemetry is recorded, moving from attributes on the tool.call.count metric to a new dedicated gemini_cli.lines.changed counter.

While this is a good structural improvement, the current implementation has lost the ability to distinguish between model-generated and user-modified line changes, and it no longer records user-initiated changes at all. My review includes suggestions to reintroduce tracking for user-modified lines and to add a source attribute to the new metric to differentiate between model and user changes. This will restore the lost telemetry data and provide more granular insights. The corresponding tests will need to be updated to reflect these suggested changes.

Comment thread packages/core/src/telemetry/metrics.ts
Comment thread packages/core/src/telemetry/metrics.ts
Comment thread packages/core/src/telemetry/loggers.ts
@jerop jerop merged commit 9fbea50 into release/v0.12.0-preview.6-pr-12299 Oct 31, 2025
26 of 27 checks passed
@jerop jerop deleted the hotfix/v0.12.0-preview.6/0.12.0-preview.7/preview/cherry-pick-135d981/pr-12299 branch October 31, 2025 15:14
@sripasg sripasg added the size/m A medium sized PR label Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/m A medium sized PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants