Skip to content

fix(patch): cherry-pick 11e1e98 to release/v0.12.0-preview.7-pr-12347 to patch version v0.12.0-preview.7 and create version 0.12.0-preview.8#12383

Merged
SandyTao520 merged 1 commit into
release/v0.12.0-preview.7-pr-12347from
hotfix/v0.12.0-preview.7/0.12.0-preview.8/preview/cherry-pick-11e1e98/pr-12347
Oct 31, 2025
Merged

fix(patch): cherry-pick 11e1e98 to release/v0.12.0-preview.7-pr-12347 to patch version v0.12.0-preview.7 and create version 0.12.0-preview.8#12383
SandyTao520 merged 1 commit into
release/v0.12.0-preview.7-pr-12347from
hotfix/v0.12.0-preview.7/0.12.0-preview.8/preview/cherry-pick-11e1e98/pr-12347

Conversation

@gemini-cli-robot

Copy link
Copy Markdown
Collaborator

This PR automatically cherry-picks commit 11e1e98 to patch version v0.12.0-preview.7 in the preview release to create version 0.12.0-preview.8.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @gemini-cli-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request delivers an automated patch release for a preview version, specifically v0.12.0-preview.8, by cherry-picking a critical commit. The primary purpose of this commit is to refine the behavior of the loop detection mechanism, ensuring that once the service is explicitly disabled, it ceases to report any further loop detections, thereby preventing unintended loop reporting.

Highlights

  • Automated Patch Release: This pull request is an automated cherry-pick to create a new patch version (v0.12.0-preview.8) for a preview release (v0.12.0-preview.7).
  • Loop Detection Logic Fix: The core change addresses a bug in the LoopDetectionService where disabling the service (disabledForSession) would not prevent addAndCheck from reporting a loop if one had already been detected. The logic is now corrected to ensure that if the service is disabled, it will always return false for loop detection.
  • New Test Case: A new test case has been added to loopDetectionService.test.ts to specifically verify that the LoopDetectionService correctly stops reporting a loop once disableForSession() is called, even if a loop was previously detected.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request cherry-picks a fix for the loop detection service. The change correctly ensures that if loop detection is disabled for a session, it stops reporting loops even if one was previously detected. The logic in addAndCheck is now more explicit and correct, prioritizing the disabled flag. A new test case has been added to verify this exact scenario. The changes look good and address the bug effectively.

@github-actions

Copy link
Copy Markdown

Size Change: +44 B (0%)

Total Size: 20.2 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 20.2 MB +44 B (0%)
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B

compressed-size-action

@SandyTao520 SandyTao520 enabled auto-merge (squash) October 31, 2025 16:25
@SandyTao520 SandyTao520 merged commit cc076e9 into release/v0.12.0-preview.7-pr-12347 Oct 31, 2025
20 of 21 checks passed
@SandyTao520 SandyTao520 deleted the hotfix/v0.12.0-preview.7/0.12.0-preview.8/preview/cherry-pick-11e1e98/pr-12347 branch October 31, 2025 16:31
@sripasg sripasg added the size/s A small PR label Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/s A small PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants