fix(patch): cherry-pick fd2cbac to release/v0.12.0-preview.9-pr-12399 [CONFLICTS]#12488
Conversation
…#12399) # Conflicts: # integration-tests/json-output.error.responses
Summary of ChangesHello @gemini-cli-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request is an automated cherry-pick of a commit that refines the model configuration logic, ensuring that explicitly chosen models are respected even when a model router is active. It also introduces a new integration test to improve error handling for file access operations. Due to detected merge conflicts, manual intervention is necessary to resolve the discrepancies and finalize the changes. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request cherry-picks a fix to prevent the model router from overriding a user-specified model. The change in packages/core/src/config/config.ts correctly removes the logic that was automatically switching the model to 'auto'. A corresponding test case has been added in packages/core/src/config/config.test.ts. My feedback focuses on improving this new test to more accurately validate the fix.
|
Size Change: -133 B (0%) Total Size: 20.2 MB ℹ️ View Unchanged
|
a2cb116
into
release/v0.12.0-preview.9-pr-12399
This PR automatically cherry-picks commit fd2cbac to patch version v0.12.0-preview.9 in the preview release to create version 0.12.0-preview.10.
This cherry-pick resulted in merge conflicts that need manual resolution.
🔧 Next Steps:
📋 Files with conflicts:
The commit has been created with conflict markers for easier manual resolution.
🚨 Important: