Skip to content

fix(patch): cherry-pick fc42c46 to release/v0.12.0-preview.9-pr-12247 to patch version v0.12.0-preview.9 and create version 0.12.0-preview.10#12533

Merged
chrstnb merged 1 commit into
release/v0.12.0-preview.9-pr-12247from
hotfix/v0.12.0-preview.9/0.12.0-preview.10/preview/cherry-pick-fc42c46/pr-12247
Nov 4, 2025
Merged

fix(patch): cherry-pick fc42c46 to release/v0.12.0-preview.9-pr-12247 to patch version v0.12.0-preview.9 and create version 0.12.0-preview.10#12533
chrstnb merged 1 commit into
release/v0.12.0-preview.9-pr-12247from
hotfix/v0.12.0-preview.9/0.12.0-preview.10/preview/cherry-pick-fc42c46/pr-12247

Conversation

@gemini-cli-robot

Copy link
Copy Markdown
Collaborator

This PR automatically cherry-picks commit fc42c46 to patch version v0.12.0-preview.9 in the preview release to create version 0.12.0-preview.10.

@gemini-cli-robot gemini-cli-robot requested a review from a team as a code owner November 4, 2025 15:57
@github-actions github-actions Bot mentioned this pull request Nov 4, 2025
18 tasks
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @gemini-cli-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request automates the application of a critical fix to a preview release branch, leading to a new preview version. The core change ensures that the screen reader-friendly view notification in the CLI is presented to the user only once, improving the user experience by avoiding redundant messages.

Highlights

  • Screen Reader Nudge Persistence: The screen reader-friendly view notification will now only be displayed once per user. A flag file is created in a temporary directory to track if the nudge has been seen, preventing repeated displays on subsequent runs.
  • Automated Cherry-Pick: This pull request is an automated cherry-pick of commit fc42c46 to apply a specific fix to the release/v0.12.0-preview.9-pr-12247 branch, resulting in the creation of version 0.12.0-preview.10.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a one-time notification for users with screen readers, informing them about the screen reader-friendly view and how to disable it. The implementation correctly uses a file-based flag to prevent showing the message on subsequent runs. However, I've identified a potential UI flicker issue in the current implementation and provided a suggestion to resolve it. Otherwise, the changes look good.

Comment on lines +53 to +54
const showScreenReaderNudge =
isScreenReaderEnabled && !hasSeenScreenReaderNudge;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The current logic for showScreenReaderNudge can cause a UI flicker. On the initial render, hasSeenScreenReaderNudge is undefined, making !hasSeenScreenReaderNudge evaluate to true. If the screen reader is enabled, the nudge will be displayed momentarily. Then, the useEffect hook runs, checks for the file, and if it exists, sets hasSeenScreenReaderNudge to true. This triggers a re-render where showScreenReaderNudge becomes false, causing the nudge to disappear.

To prevent this flicker, you should only show the nudge when you are certain it should be displayed, i.e., after the check has completed and hasSeenScreenReaderNudge is explicitly false.

Suggested change
const showScreenReaderNudge =
isScreenReaderEnabled && !hasSeenScreenReaderNudge;
const showScreenReaderNudge =
isScreenReaderEnabled && hasSeenScreenReaderNudge === false;

@github-actions

github-actions Bot commented Nov 4, 2025

Copy link
Copy Markdown

Size Change: +1.33 kB (+0.01%)

Total Size: 20.2 MB

Filename Size Change
./bundle/gemini.js 20.2 MB +1.33 kB (+0.01%)
ℹ️ View Unchanged
Filename Size
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB
./bundle/sandbox-macos-permissive-open.sb 890 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB

compressed-size-action

@chrstnb chrstnb merged commit c447183 into release/v0.12.0-preview.9-pr-12247 Nov 4, 2025
20 of 21 checks passed
@chrstnb chrstnb deleted the hotfix/v0.12.0-preview.9/0.12.0-preview.10/preview/cherry-pick-fc42c46/pr-12247 branch November 4, 2025 16:44
@sripasg sripasg added the size/m A medium sized PR label Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/m A medium sized PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants