Fix/windows pty crash#12587
Conversation
On Windows, a race condition can occur where a resize event is processed for a pseudo-terminal (pty) that has already exited. This was throwing an unhandled error, 'Cannot resize a pty that has already exited,' causing the entire CLI process to crash. The existing error handling in resizePty only checked for the ESRCH error code, which is specific to Unix-like systems. This change updates the catch block to also identify the Windows-specific error message, allowing the error to be safely ignored in the same way as its Unix counterpart. This improves the stability of shell command execution on Windows, especially for short-lived commands.
This commit introduces a ry...catch block around the ShellExecutionService.resizePty call within AppContainer.tsx. This acts as a safeguard to prevent the UI from crashing if the underlying pty process exits unexpectedly before the resize operation can complete. This change provides an additional layer of resilience and prevents the entire CLI from terminating due to this specific race condition on Windows.
Adds two regression tests to ensure the CLI does not crash when a pty process exits before a resize operation can be performed. This scenario was causing crashes on Windows. - A test in `AppContainer.test.tsx` simulates the error being thrown during a render cycle and asserts that the component does not crash. - A test in `shellExecutionService.test.ts` directly tests the `resizePty` method, ensuring it catches the specific error and does not re-throw it. This addresses the feedback from the pull request review to ensure the fix is robust and prevents future regressions.
Summary of ChangesHello @bdmorgan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces critical fixes to address a specific crash scenario on Windows where the application would fail when attempting to resize a pseudo-terminal (pty) that had already terminated. By implementing robust error handling and adding targeted tests, the changes significantly improve the stability and resilience of the application, particularly for users on Windows operating systems, ensuring a smoother user experience. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses a crash on Windows that occurs when trying to resize a PTY that has already exited. The fix involves adding error handling to gracefully manage this race condition. The changes are sound and include necessary test updates. However, I've identified a redundant try-catch block in AppContainer.tsx, as the error is already handled within the ShellExecutionService. Removing this duplication will improve code clarity and maintainability. I've also suggested a small refactoring in shellExecutionService.ts to simplify an if condition. The other changes, mostly related to test timeouts and configurations, appear reasonable.
|
Size Change: +229 B (0%) Total Size: 20.4 MB ℹ️ View Unchanged
|
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
Finally !! Thx |
|
/patch preview |
|
✅ Patch workflow(s) dispatched successfully! 📋 Details:
🔗 Track Progress: |
Co-authored-by: LayorX <yor31117@gmail.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
🚀 Patch PR Created! 📋 Patch Details:
📝 Next Steps:
🔗 Track Progress: |
|
🚀 Patch Release Started! 📋 Release Details:
⏳ Status: The patch release is now running. You'll receive another update when it completes. 🔗 Track Progress: |
|
✅ Patch Release Complete! 📦 Release Details:
🎉 Status: Your patch has been successfully released and published to npm! 📝 What's Available:
🔗 Links: |
Co-authored-by: LayorX <yor31117@gmail.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
NO SUCH THING. IT NEVER FIXED. IT NEVER FIXED. |
Co-authored-by: LayorX <yor31117@gmail.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
6 participants
These are fixes for PR #11559