Skip to content

fix(patch): cherry-pick f51d745 to release/v0.13.0-preview.0-pr-12586 to patch version v0.13.0-preview.0 and create version 0.13.0-preview.1#12595

Merged
skeshive merged 1 commit into
release/v0.13.0-preview.0-pr-12586from
hotfix/v0.13.0-preview.0/0.13.0-preview.1/preview/cherry-pick-f51d745/pr-12586
Nov 5, 2025
Merged

fix(patch): cherry-pick f51d745 to release/v0.13.0-preview.0-pr-12586 to patch version v0.13.0-preview.0 and create version 0.13.0-preview.1#12595
skeshive merged 1 commit into
release/v0.13.0-preview.0-pr-12586from
hotfix/v0.13.0-preview.0/0.13.0-preview.1/preview/cherry-pick-f51d745/pr-12586

Conversation

@gemini-cli-robot

Copy link
Copy Markdown
Collaborator

This PR automatically cherry-picks commit f51d745 to patch version v0.13.0-preview.0 in the preview release to create version 0.13.0-preview.1.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @gemini-cli-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on refining the error handling logic for Google API quota errors. It enhances the ability to detect and interpret retry delays embedded within error messages, including those expressed in milliseconds. This improvement allows for more precise and adaptive retry strategies when encountering rate limits, ultimately leading to more resilient and efficient interactions with Google APIs.

Highlights

  • Enhanced Quota Error Classification: The system for classifying Google API quota errors has been improved to better identify retryable errors based on specific messages.
  • Millisecond Retry Delay Support: The parseDurationInSeconds utility now correctly handles retry delay durations specified in milliseconds (e.g., '900ms') in addition to seconds ('44s').
  • Robust Error Message Parsing: A new fallback mechanism has been added to classifyGoogleError to extract retry delays directly from the raw error message string, even if the structured Google API error object is not fully available or parsable, looking for patterns like 'Please retry in X[s|ms]'.
  • Improved Test Coverage: New unit tests have been introduced to ensure the accurate parsing and classification of RetryableQuotaError instances when retry delays are present in error messages, covering both second and millisecond formats.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@skeshive skeshive self-requested a review November 5, 2025 16:57

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a fallback mechanism to handle Google API quota errors where the retry delay is specified in the error message string. The change correctly extends parseDurationInSeconds to handle milliseconds and adds tests for the new logic. However, I've found a potential logic issue in the implementation of the fallback mechanism in classifyGoogleError that could lead to misclassifying non-quota errors. My review includes a suggestion to correct this to ensure the fallback is only applied in the intended scenarios.

Comment thread packages/core/src/utils/googleQuotaErrors.ts
@skeshive skeshive enabled auto-merge (squash) November 5, 2025 16:57
@github-actions

github-actions Bot commented Nov 5, 2025

Copy link
Copy Markdown

Size Change: +685 B (0%)

Total Size: 20.4 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 20.4 MB +685 B (0%)
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B

compressed-size-action

@skeshive skeshive merged commit fd885a3 into release/v0.13.0-preview.0-pr-12586 Nov 5, 2025
21 checks passed
@skeshive skeshive deleted the hotfix/v0.13.0-preview.0/0.13.0-preview.1/preview/cherry-pick-f51d745/pr-12586 branch November 5, 2025 17:04
@sripasg sripasg added the size/m A medium sized PR label Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/m A medium sized PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants