fix(editor): ensure preferred editor setting updates immediately#12981
Conversation
Previously, the preferred editor setting was saved to 'preferredEditor' but read from 'general.preferredEditor', requiring a session restart for the migration to run. This change centralizes the setting path to 'general.preferredEditor' to ensure consistency between read and write operations.
Summary of ChangesHello @abhipatel12, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a bug where changes to the preferred editor setting in the CLI did not apply until a session restart. The issue stemmed from a mismatch between the setting key used for writing and reading. The fix involves introducing a new Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively fixes a bug preventing the preferred editor setting from updating immediately. By introducing a SettingPaths constant and using the correct V2 path for writing the setting, you've resolved the issue and improved code maintainability by eliminating a magic string. The changes are solid. I have one suggestion to further enhance consistency by applying this new pattern more broadly.
|
Size Change: +200 B (0%) Total Size: 20.5 MB ℹ️ View Unchanged
|
…updates immediately (google-gemini#12981)
|
/patch preview |
|
✅ Patch workflow(s) dispatched successfully! 📋 Details:
🔗 Track Progress: |
|
🚀 Patch PR Created! 📋 Patch Details:
📝 Next Steps:
🔗 Track Progress: |
|
🚀 Patch Release Started! 📋 Release Details:
⏳ Status: The patch release is now running. You'll receive another update when it completes. 🔗 Track Progress: |
|
✅ Patch Release Complete! 📦 Release Details:
🎉 Status: Your patch has been successfully released and published to npm! 📝 What's Available:
🔗 Links: |
3 participants
Summary
Fixes a bug where changing the preferred editor required a session restart to take effect. This was caused by a mismatch between the setting key used for writing (
preferredEditor) and reading (general.preferredEditor).Details
SettingPathsconstant to centralize setting keys and avoid magic strings.useEditorSettingsto useSettingPaths.General.PreferredEditor.MIGRATION_MAPinsettings.tsto use the same constant, ensuring consistency.general.preferredEditor, which is whereAppContainerreads it from, bypassing the need for a restart-triggered migration.Related Issues
Fixes the editor preference update delay.
Created #12982 to track a follow-up clean up task
How to Validate
/editorand select an editor (e.g.,vim).vim./editoragain and select a different editor (e.g.,nanoorvscode).Pre-Merge Checklist