fix(patch): cherry-pick fe1bfc6 to release/v0.15.0-preview.2-pr-12989 to patch version v0.15.0-preview.2 and create version 0.15.0-preview.3#12990
Conversation
Summary of ChangesHello @gemini-cli-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request cherry-picks a commit to enhance the visual experience of the CLI by introducing adaptive ASCII art rendering for its header. It refactors the terminal detection mechanism and integrates new IDE-specific ASCII logos, which are conditionally displayed when the CLI operates within an integrated development environment. This change aims to improve the aesthetic and readability of the CLI's branding in various terminal contexts. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces new ASCII art logos for IDE environments and refactors the terminal detection logic to support this feature. The changes are generally well-implemented and include new tests for the updated behavior. However, I've identified a high-severity bug in the logic that selects which logo to display. The width calculation for the logos doesn't account for the potentially different sizes of the new IDE-specific art, which can lead to layout issues like wrapping. I've provided a specific code suggestion to address this rendering bug.
| const widthOfLongLogo = getAsciiArtWidth(longAsciiLogo); | ||
| const widthOfShortLogo = getAsciiArtWidth(shortAsciiLogo); |
There was a problem hiding this comment.
The logic for determining which logo to display is based on the width of the default logos (longAsciiLogo, shortAsciiLogo). However, when running in an IDE, an alternative logo (...Ide) is chosen which might be wider. This can cause the ASCII art to wrap and break the layout if the terminal width is sufficient for the default logo but not for the wider IDE logo.
For example, longAsciiLogo is 87 characters wide, while longAsciiLogoIde is 88. If the terminal width is 87, the current logic would select longAsciiLogoIde, causing it to wrap.
To fix this, the width check should consider the maximum width between the default and the IDE-specific logos to ensure the selected art always fits.
const widthOfLongLogo = Math.max(
getAsciiArtWidth(longAsciiLogo),
getAsciiArtWidth(longAsciiLogoIde)
);
const widthOfShortLogo = Math.max(
getAsciiArtWidth(shortAsciiLogo),
getAsciiArtWidth(shortAsciiLogoIde)
);
|
Size Change: +7.66 kB (+0.04%) Total Size: 20.5 MB
ℹ️ View Unchanged
|
605d916
into
release/v0.15.0-preview.2-pr-12989
This PR automatically cherry-picks commit fe1bfc6 to patch version v0.15.0-preview.2 in the preview release to create version 0.15.0-preview.3.