Skip to content

fix(patch): cherry-pick fe1bfc6 to release/v0.15.0-preview.2-pr-12989 to patch version v0.15.0-preview.2 and create version 0.15.0-preview.3#12990

Merged
SandyTao520 merged 1 commit into
release/v0.15.0-preview.2-pr-12989from
hotfix/v0.15.0-preview.2/0.15.0-preview.3/preview/cherry-pick-fe1bfc6/pr-12989
Nov 13, 2025
Merged

fix(patch): cherry-pick fe1bfc6 to release/v0.15.0-preview.2-pr-12989 to patch version v0.15.0-preview.2 and create version 0.15.0-preview.3#12990
SandyTao520 merged 1 commit into
release/v0.15.0-preview.2-pr-12989from
hotfix/v0.15.0-preview.2/0.15.0-preview.3/preview/cherry-pick-fe1bfc6/pr-12989

Conversation

@gemini-cli-robot

Copy link
Copy Markdown
Collaborator

This PR automatically cherry-picks commit fe1bfc6 to patch version v0.15.0-preview.2 in the preview release to create version 0.15.0-preview.3.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @gemini-cli-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request cherry-picks a commit to enhance the visual experience of the CLI by introducing adaptive ASCII art rendering for its header. It refactors the terminal detection mechanism and integrates new IDE-specific ASCII logos, which are conditionally displayed when the CLI operates within an integrated development environment. This change aims to improve the aesthetic and readability of the CLI's branding in various terminal contexts.

Highlights

  • IDE-specific ASCII Art: New variants of the CLI's ASCII art logos have been introduced, specifically designed for display when the application is running within an Integrated Development Environment (IDE).
  • Adaptive Header Rendering: The CLI header now intelligently detects if it's running in an IDE and, if so, uses the newly added IDE-optimized ASCII logos to ensure better visual presentation.
  • Terminal Detection Refinement: The utility for detecting the current terminal program has been refactored, making the detection logic more modular and accessible for use in different parts of the application.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces new ASCII art logos for IDE environments and refactors the terminal detection logic to support this feature. The changes are generally well-implemented and include new tests for the updated behavior. However, I've identified a high-severity bug in the logic that selects which logo to display. The width calculation for the logos doesn't account for the potentially different sizes of the new IDE-specific art, which can lead to layout issues like wrapping. I've provided a specific code suggestion to address this rendering bug.

Comment on lines 57 to 58
const widthOfLongLogo = getAsciiArtWidth(longAsciiLogo);
const widthOfShortLogo = getAsciiArtWidth(shortAsciiLogo);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The logic for determining which logo to display is based on the width of the default logos (longAsciiLogo, shortAsciiLogo). However, when running in an IDE, an alternative logo (...Ide) is chosen which might be wider. This can cause the ASCII art to wrap and break the layout if the terminal width is sufficient for the default logo but not for the wider IDE logo.

For example, longAsciiLogo is 87 characters wide, while longAsciiLogoIde is 88. If the terminal width is 87, the current logic would select longAsciiLogoIde, causing it to wrap.

To fix this, the width check should consider the maximum width between the default and the IDE-specific logos to ensure the selected art always fits.

  const widthOfLongLogo = Math.max(
    getAsciiArtWidth(longAsciiLogo),
    getAsciiArtWidth(longAsciiLogoIde)
  );
  const widthOfShortLogo = Math.max(
    getAsciiArtWidth(shortAsciiLogo),
    getAsciiArtWidth(shortAsciiLogoIde)
  );

@github-actions

Copy link
Copy Markdown

Size Change: +7.66 kB (+0.04%)

Total Size: 20.5 MB

Filename Size Change
./bundle/gemini.js 20.5 MB +7.66 kB (+0.04%)
ℹ️ View Unchanged
Filename Size
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB
./bundle/sandbox-macos-permissive-open.sb 890 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB

compressed-size-action

@SandyTao520 SandyTao520 merged commit 605d916 into release/v0.15.0-preview.2-pr-12989 Nov 13, 2025
21 checks passed
@SandyTao520 SandyTao520 deleted the hotfix/v0.15.0-preview.2/0.15.0-preview.3/preview/cherry-pick-fe1bfc6/pr-12989 branch November 13, 2025 08:16
@sripasg sripasg added the size/m A medium sized PR label Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/m A medium sized PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants