Skip to content

fix(patch): cherry-pick 13d8d94 to release/v0.15.0-preview.4-pr-12981 to patch version v0.15.0-preview.4 and create version 0.15.0-preview.5#13011

Merged
abhipatel12 merged 1 commit into
release/v0.15.0-preview.4-pr-12981from
hotfix/v0.15.0-preview.4/0.15.0-preview.5/preview/cherry-pick-13d8d94/pr-12981
Nov 13, 2025
Merged

fix(patch): cherry-pick 13d8d94 to release/v0.15.0-preview.4-pr-12981 to patch version v0.15.0-preview.4 and create version 0.15.0-preview.5#13011
abhipatel12 merged 1 commit into
release/v0.15.0-preview.4-pr-12981from
hotfix/v0.15.0-preview.4/0.15.0-preview.5/preview/cherry-pick-13d8d94/pr-12981

Conversation

@gemini-cli-robot

Copy link
Copy Markdown
Collaborator

This PR automatically cherry-picks commit 13d8d94 to patch version v0.15.0-preview.4 in the preview release to create version 0.15.0-preview.5.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @gemini-cli-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request automates the cherry-picking of a specific commit to a preview release branch, resulting in a new patch version. The underlying change introduces a new file, settingPaths.ts, which centralizes the definition of configuration path strings. This refactoring improves code maintainability by replacing hardcoded string literals with a constant, ensuring consistency across the codebase where settings are accessed or modified.

Highlights

  • Centralized Setting Paths: Introduced a new file, settingPaths.ts, to define and centralize string literals for configuration paths, specifically for General.PreferredEditor.
  • Improved Maintainability: Replaced direct string usage of 'general.preferredEditor' with the new SettingPaths.General.PreferredEditor constant across relevant files, enhancing code consistency and reducing potential for typos.
  • Automated Cherry-Pick: This pull request is an automated cherry-pick of a specific commit to apply a fix to a preview release branch, creating a new patch version.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly refactors the hardcoded setting path for preferredEditor into a new SettingPaths constant, and in doing so, fixes a bug where an incorrect, legacy setting key was being used. This is a good improvement for maintainability and correctness. My review includes a suggestion to improve the consistency of the new SettingPaths object by aligning its key casing with the actual settings schema. I've provided detailed comments and code suggestions to apply this change across all affected files.

Comment thread packages/cli/src/config/settingPaths.ts
Comment thread packages/cli/src/config/settings.ts
Comment thread packages/cli/src/ui/hooks/useEditorSettings.test.tsx
Comment thread packages/cli/src/ui/hooks/useEditorSettings.test.tsx
Comment thread packages/cli/src/ui/hooks/useEditorSettings.test.tsx
Comment thread packages/cli/src/ui/hooks/useEditorSettings.test.tsx
Comment thread packages/cli/src/ui/hooks/useEditorSettings.ts
@github-actions

Copy link
Copy Markdown

Size Change: +200 B (0%)

Total Size: 20.5 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 20.5 MB +200 B (0%)
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B

compressed-size-action

@abhipatel12

Copy link
Copy Markdown
Contributor

Tested locally and approved

@abhipatel12 abhipatel12 merged commit 77751a0 into release/v0.15.0-preview.4-pr-12981 Nov 13, 2025
21 checks passed
@abhipatel12 abhipatel12 deleted the hotfix/v0.15.0-preview.4/0.15.0-preview.5/preview/cherry-pick-13d8d94/pr-12981 branch November 13, 2025 17:48
@sripasg sripasg added the size/s A small PR label Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/s A small PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants