Skip to content

fix(patch): cherry-pick ce56b4e to release/v0.16.0-preview.1-pr-13073 to patch version v0.16.0-preview.1 and create version 0.16.0-preview.2#13097

Merged
skeshive merged 1 commit into
release/v0.16.0-preview.1-pr-13073from
hotfix/v0.16.0-preview.1/0.16.0-preview.2/preview/cherry-pick-ce56b4e/pr-13073
Nov 14, 2025
Merged

fix(patch): cherry-pick ce56b4e to release/v0.16.0-preview.1-pr-13073 to patch version v0.16.0-preview.1 and create version 0.16.0-preview.2#13097
skeshive merged 1 commit into
release/v0.16.0-preview.1-pr-13073from
hotfix/v0.16.0-preview.1/0.16.0-preview.2/preview/cherry-pick-ce56b4e/pr-13073

Conversation

@gemini-cli-robot

Copy link
Copy Markdown
Collaborator

This PR automatically cherry-picks commit ce56b4e to patch version v0.16.0-preview.1 in the preview release to create version 0.16.0-preview.2.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @gemini-cli-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request is an automated cherry-pick to update a preview release, focusing on a significant refactoring of how experiment flags are managed. The core change transitions the identification of experiment flags from descriptive string names to unique numeric IDs. This update impacts data structures, parsing mechanisms, and how experiment information is presented in configuration summaries, aiming for a more robust and potentially more performant system for handling experiments.

Highlights

  • Experiment Flag Identification: The system now identifies experiment flags using numeric flagIds instead of string names, improving consistency and potentially performance.
  • Interface and Constant Updates: The Flag interface has been updated to include flagId?: number, and ExperimentFlags constants now use numeric IDs instead of string names.
  • Parsing and Configuration Logic: The logic for parsing experiment responses and generating configuration summaries has been adjusted to correctly process and display the new flagIds.
  • Test Case Refinement: Existing test cases for experiment flags have been updated to reflect the change from string names to numeric IDs, ensuring correct functionality.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the experiment flag identification from string-based names to numeric IDs. The changes are consistent across tests, type definitions, and implementation. I've found one potential issue where a flag with an ID of 0 would be incorrectly ignored. I've provided a suggestion to fix this.

for (const flag of response.flags ?? []) {
if (flag.name) {
flags[flag.name] = flag;
if (flag.flagId) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The check if (flag.flagId) will evaluate to false if flagId is 0. While current flag IDs appear to be large positive numbers, 0 is a valid number and could potentially be used as a flag ID in the future. This would cause the flag to be silently ignored. Using flag.flagId != null is safer as it correctly handles 0 while still filtering out null and undefined values.

Suggested change
if (flag.flagId) {
if (flag.flagId != null) {

@github-actions

Copy link
Copy Markdown

Size Change: -66 B (0%)

Total Size: 20.5 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 20.5 MB -66 B (0%)
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B

compressed-size-action

@skeshive skeshive merged commit cc608b9 into release/v0.16.0-preview.1-pr-13073 Nov 14, 2025
21 checks passed
@skeshive skeshive deleted the hotfix/v0.16.0-preview.1/0.16.0-preview.2/preview/cherry-pick-ce56b4e/pr-13073 branch November 14, 2025 22:01
@sripasg sripasg added the size/s A small PR label Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/s A small PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants