Skip to content

fix(patch): cherry-pick ab6b229 to release/v0.15.1-pr-13101 to patch version v0.15.1 and create version 0.15.2#13111

Merged
jacob314 merged 1 commit into
release/v0.15.1-pr-13101from
hotfix/v0.15.1/0.15.2/stable/cherry-pick-ab6b229/pr-13101
Nov 15, 2025
Merged

fix(patch): cherry-pick ab6b229 to release/v0.15.1-pr-13101 to patch version v0.15.1 and create version 0.15.2#13111
jacob314 merged 1 commit into
release/v0.15.1-pr-13101from
hotfix/v0.15.1/0.15.2/stable/cherry-pick-ab6b229/pr-13101

Conversation

@gemini-cli-robot

Copy link
Copy Markdown
Collaborator

This PR automatically cherry-picks commit ab6b229 to patch version v0.15.1 in the stable release to create version 0.15.2.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @gemini-cli-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request automates the creation of a patch release, version "0.15.2", by cherry-picking a specific commit. The primary functional change involves enhancing the system's ability to differentiate between various mouse button presses during events, particularly for drag interactions, by introducing a "button" property to mouse events and updating the parsing and handling logic accordingly. This ensures more precise and intended mouse behavior within the application.

Highlights

  • Automated Patch Release: This pull request is an automated cherry-pick of commit "ab6b2293e1e0c1f39846dc8c4e43fd9def8a50ce" to create version "0.15.2" from the "v0.15.1" stable release.
  • Enhanced Mouse Event Handling: The MouseEvent interface has been extended to include a "button" property, allowing for more granular control over mouse interactions, specifically distinguishing between left, middle, right, and no button presses.
  • Mouse Drag Logic Refinement: The MouseProvider now explicitly checks for "event.button === 'left'" when handling mouse 'move' events, ensuring that drag operations are correctly identified and processed only when the left mouse button is pressed.
  • Mouse Event Parsing Updates: The "parseSGRMouseEvent" and "parseX11MouseEvent" utility functions have been updated to correctly parse and include the "button" information from incoming mouse event buffers.
  • Comprehensive Test Coverage: Numerous test cases across "ScrollProvider.drag.test.tsx", "ScrollProvider.test.tsx", and "mouse.test.ts" have been updated to reflect the new "button" property in simulated mouse events, ensuring the robustness of the new mouse handling logic.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request cherry-picks a fix to correctly handle mouse drag events, ensuring that only left-button drags trigger certain UI behaviors. This is implemented by adding a button property to the MouseEvent type and populating it during mouse event parsing for both SGR and X11 protocols. The changes are logical and well-tested. I have one suggestion to improve the maintainability of the X11 parsing logic, but otherwise, the changes look solid.

Comment on lines +185 to +187
if (name === 'left-release' && button === 'none') {
button = 'left';
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The condition name === 'left-release' && button === 'none' is brittle as it relies on coupling between the name variable (set earlier in the function) and the result of getButtonFromCode. A more direct and robust approach is to check the button code from b directly. This avoids the indirect dependency on name and makes the logic for handling the ambiguous X11 release event clearer and more maintainable.

Suggested change
if (name === 'left-release' && button === 'none') {
button = 'left';
}
if ((b & 3) === 3) {
button = 'left';
}

@github-actions

Copy link
Copy Markdown

Size Change: +495 B (0%)

Total Size: 20.5 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 20.5 MB +495 B (0%)
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B

compressed-size-action

@jacob314 jacob314 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jacob314 jacob314 merged commit 4067f85 into release/v0.15.1-pr-13101 Nov 15, 2025
20 of 21 checks passed
@jacob314 jacob314 deleted the hotfix/v0.15.1/0.15.2/stable/cherry-pick-ab6b229/pr-13101 branch November 15, 2025 01:31
@sripasg sripasg added the size/m A medium sized PR label Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/m A medium sized PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants