Skip to content

fix(patch): cherry-pick d03496b to release/v0.15.2-pr-13099 to patch version v0.15.2 and create version 0.15.3#13144

Merged
SandyTao520 merged 1 commit into
release/v0.15.2-pr-13099from
hotfix/v0.15.2/0.15.3/stable/cherry-pick-d03496b/pr-13099
Nov 15, 2025
Merged

fix(patch): cherry-pick d03496b to release/v0.15.2-pr-13099 to patch version v0.15.2 and create version 0.15.3#13144
SandyTao520 merged 1 commit into
release/v0.15.2-pr-13099from
hotfix/v0.15.2/0.15.3/stable/cherry-pick-d03496b/pr-13099

Conversation

@gemini-cli-robot

Copy link
Copy Markdown
Collaborator

This PR automatically cherry-picks commit d03496b to patch version v0.15.2 in the stable release to create version 0.15.3.

@gemini-cli-robot gemini-cli-robot requested a review from a team as a code owner November 15, 2025 18:28
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @gemini-cli-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request consolidates the UI's warning display logic by introducing a generic warningMessage state, allowing for more flexible warning notifications. It also addresses potential issues with large paste operations by significantly extending the paste timeout duration and providing a user-facing warning if a paste operation fails due to a timeout. This improves the user experience by providing clearer feedback for various UI-related events.

Highlights

  • Unified Warning System: The UI state management for warnings has been refactored to use a single warningMessage state variable, replacing the previous selectionWarning boolean. This allows for more generic and flexible display of warning messages to the user.
  • Enhanced Paste Timeout Handling: A new mechanism has been implemented to detect and display a warning when a paste operation times out. The PASTE_TIMEOUT constant has been significantly increased from 50ms to 30,000ms (30 seconds) to accommodate larger paste operations, and an AppEvent.PasteTimeout is now emitted upon timeout.
  • Event-Driven Warning Integration: The new paste timeout warning is integrated into the existing event-driven system, utilizing AppEvent.PasteTimeout to trigger the display of the relevant message, aligning with how other UI warnings are handled.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the warning message system to be more generic and fixes an issue with paste operations timing out too quickly. A new warning message is now displayed when a paste times out. The changes are a good improvement, but I've identified one high-severity issue where partially pasted content is processed upon timeout, which could lead to unintended behavior. I've provided a suggestion to fix this.

Comment on lines +215 to +218
if (key === null) {
appEvents.emit(AppEvent.PasteTimeout);
break;
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Upon a paste timeout, a warning is correctly emitted. However, the partially pasted content in the buffer is still processed afterwards. This can lead to the execution of incomplete and potentially erroneous commands. To prevent this, the buffer should be cleared when a timeout occurs.

Suggested change
if (key === null) {
appEvents.emit(AppEvent.PasteTimeout);
break;
}
if (key === null) {
appEvents.emit(AppEvent.PasteTimeout);
buffer = '';
break;
}

@github-actions

Copy link
Copy Markdown

Size Change: +401 B (0%)

Total Size: 20.5 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 20.5 MB +401 B (0%)
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B

compressed-size-action

@jacob314 jacob314 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SandyTao520 SandyTao520 merged commit a9789ae into release/v0.15.2-pr-13099 Nov 15, 2025
21 checks passed
@SandyTao520 SandyTao520 deleted the hotfix/v0.15.2/0.15.3/stable/cherry-pick-d03496b/pr-13099 branch November 15, 2025 18:54
@sripasg sripasg added the size/s A small PR label Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/s A small PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants