Skip to content

fix(patch): cherry-pick 78a28bf to release/v0.15.3-pr-13188 to patch version v0.15.3 and create version 0.15.4#13228

Merged
skeshive merged 1 commit into
release/v0.15.3-pr-13188from
hotfix/v0.15.3/0.15.4/stable/cherry-pick-78a28bf/pr-13188
Nov 17, 2025
Merged

fix(patch): cherry-pick 78a28bf to release/v0.15.3-pr-13188 to patch version v0.15.3 and create version 0.15.4#13228
skeshive merged 1 commit into
release/v0.15.3-pr-13188from
hotfix/v0.15.3/0.15.4/stable/cherry-pick-78a28bf/pr-13188

Conversation

@gemini-cli-robot

Copy link
Copy Markdown
Collaborator

This PR automatically cherry-picks commit 78a28bf to patch version v0.15.3 in the stable release to create version 0.15.4.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @gemini-cli-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the robustness and maintainability of the CLI's user interface, particularly concerning gradient rendering and animation stability. It centralizes gradient logic into a dedicated component, fortifies color interpolation against invalid inputs, and addresses a critical edge case in animation handling to prevent crashes under unusual system conditions. These changes collectively improve the UI's resilience and consistency.

Highlights

  • UI Gradient Refactoring: The logic for rendering text with gradients in UI components (like Footer and StatsDisplay) has been centralized into a new reusable ThemedGradient component. This component intelligently handles cases where the theme's gradient definition might be empty, contain a single color, or multiple colors, ensuring consistent and robust rendering.
  • Improved Color Interpolation Robustness: The interpolateColor utility function has been enhanced to handle edge cases more gracefully. It now includes checks for factor values outside the 0-1 range and explicitly returns an empty string if either input color is invalid, preventing potential issues with color calculations.
  • Animation Stability Fix: A potential crash in the useAnimatedScrollbar hook, which could occur if the system's Date.now() unexpectedly went backward, has been addressed. The animation progress calculation now uses Math.max(0, Math.min(elapsed / duration, 1)) to ensure the progress value always stays within a valid range, preventing negative progress and related rendering errors.
  • New Regression Tests: New regression tests have been added to cover the identified issues. This includes tests for UI components to ensure they do not crash when theme gradients are empty or malformed, and a specific test for the useAnimatedScrollbar hook to verify its stability when Date.now() behaves unexpectedly.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a series of robust fixes to prevent UI crashes and handle edge cases more gracefully. A new ThemedGradient component has been extracted to safely render gradients, addressing crashes when theme gradients are not properly defined. Additionally, the animated scrollbar hook and color interpolation utilities have been hardened against unexpected values, such as system time moving backward or empty color strings. These changes are well-implemented and are accompanied by thorough regression tests, significantly improving the UI's stability and resilience.

@github-actions

Copy link
Copy Markdown

Size Change: +72 B (0%)

Total Size: 20.5 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 20.5 MB +72 B (0%)
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B

compressed-size-action

@jacob314 jacob314 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@skeshive skeshive enabled auto-merge (squash) November 17, 2025 15:51
@skeshive skeshive merged commit 60407da into release/v0.15.3-pr-13188 Nov 17, 2025
21 checks passed
@skeshive skeshive deleted the hotfix/v0.15.3/0.15.4/stable/cherry-pick-78a28bf/pr-13188 branch November 17, 2025 16:02
@sripasg sripasg added the size/m A medium sized PR label Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/m A medium sized PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants