fix(patch): cherry-pick 78a28bf to release/v0.16.0-preview.4-pr-13188 to patch version v0.16.0-preview.4 and create version 0.16.0-preview.5#13229
Conversation
Summary of ChangesHello @gemini-cli-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request is an automated cherry-pick that focuses on enhancing the stability and maintainability of the CLI's user interface components. It centralizes gradient rendering logic into a dedicated, more robust component and fortifies animation and color utility functions against edge cases and potential runtime issues. These improvements are backed by new regression tests, ensuring the UI remains resilient and performs as expected under various conditions. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces several important fixes. It refactors gradient rendering to use a new ThemedGradient component, preventing crashes when theme gradients are not properly configured. It also adds robustness to color interpolation and scrollbar animations, particularly against system time changes and invalid color values. The changes are well-tested with new regression tests. My main feedback is about a visual regression in StatsDisplay.tsx where the refactoring to ThemedGradient removed specific color logic for the title, which should be restored.
| if (title) { | ||
| return theme.ui.gradient && theme.ui.gradient.length > 0 ? ( | ||
| <Gradient colors={theme.ui.gradient}> | ||
| <Text bold color={theme.text.primary}> | ||
| {title} | ||
| </Text> | ||
| </Gradient> | ||
| ) : ( | ||
| <Text bold color={theme.text.accent}> | ||
| {title} | ||
| </Text> | ||
| ); | ||
| return <ThemedGradient bold>{title}</ThemedGradient>; | ||
| } |
There was a problem hiding this comment.
This refactoring to use ThemedGradient has caused a visual regression. The original implementation used theme.text.primary for the title color when a gradient was present, and theme.text.accent as a fallback when no gradient was available. The new implementation doesn't specify any color, so it will fall back to the default text color in both cases.
To restore the original behavior, you should determine the color based on the presence of a gradient and pass it to ThemedGradient.
if (title) {
const color = (theme.ui.gradient?.length ?? 0) > 0 ? theme.text.primary : theme.text.accent;
return <ThemedGradient bold color={color}>{title}</ThemedGradient>;
}
|
Size Change: +72 B (0%) Total Size: 20.5 MB ℹ️ View Unchanged
|
skeshive
merged commit 3cbb170
into
release/v0.16.0-preview.4-pr-13188
skeshive
deleted the
hotfix/v0.16.0-preview.4/0.16.0-preview.5/preview/cherry-pick-78a28bf/pr-13188
branch
4 participants
This PR automatically cherry-picks commit 78a28bf to patch version v0.16.0-preview.4 in the preview release to create version 0.16.0-preview.5.