Fix: add back fastreturn support

[scidomino]

Summary

Add fast return buffering for older terminals that don't support bracketed paste mode.

Details

We removed this in #16179 but it looks like it is still needed in some cases.

Related Issues

Fixes #15849

Pre-Merge Checklist

• Updated relevant documentation and README (if needed)
• Added/updated tests (if needed)
• Noted breaking changes (if any)
• Validated on required platforms/methods:
  • MacOS
    • npm run
    • npx
    • Docker
    • Podman
    • Seatbelt
  • Windows
    • npm run
    • npx
    • Docker
  • Linux
    • npm run
    • npx
    • Docker

[gemini-code-assist]

Summary of Changes

Hello @scidomino, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to resolve input issues experienced by users on older terminal emulators. By re-implementing a fast return buffering mechanism, it ensures that return key presses are correctly interpreted, particularly when bracketed paste mode is not supported. This change enhances the application's robustness and user experience across a broader range of terminal environments.

Highlights

• Reintroduction of Fast Return Buffering: This pull request reintroduces fast return buffering to improve compatibility with older terminals that do not support bracketed paste mode, addressing issues where quick return key presses might be misinterpreted.
• New bufferFastReturn Function: A new utility function, bufferFastReturn, has been added to convert return keys pressed quickly after other keys into plain insertable return characters, ensuring correct input handling.
• Conditional Application of Buffering: The bufferFastReturn logic is conditionally applied within the keypress processing pipeline, specifically when the terminal does not have Kitty protocol enabled, ensuring modern terminals are not affected.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request re-introduces fast return buffering to support older terminals that lack bracketed paste mode, addressing a regression. The implementation is well-contained and conditionally applied, which is a good approach. However, a key concern is the absence of unit tests for the new bufferFastReturn function. Since this logic modifies user input based on timing, adding tests is critical to ensure its correctness and prevent future issues.

[github-actions]

Size Change: +484 B (0%)

Total Size: 22.3 MB

ℹ️ View Unchanged

Filename	Size	Change
./bundle/gemini.js	22.3 MB	+484 B (0%)
./bundle/sandbox-macos-permissive-closed.sb	1.03 kB	0 B
./bundle/sandbox-macos-permissive-open.sb	890 B	0 B
./bundle/sandbox-macos-permissive-proxied.sb	1.31 kB	0 B
./bundle/sandbox-macos-restrictive-closed.sb	3.29 kB	0 B
./bundle/sandbox-macos-restrictive-open.sb	3.36 kB	0 B
./bundle/sandbox-macos-restrictive-proxied.sb	3.56 kB	0 B

_{compressed-size-action}

[jacob314]