fix(patch): cherry-pick 87a0db2 to release/v0.26.0-preview.1-pr-17308 [CONFLICTS]#17317
Conversation
# Conflicts: # packages/cli/src/gemini.tsx
Summary of ChangesHello @gemini-cli-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request is an automated cherry-pick of a fix aimed at improving the robustness of the CLI's authentication process. The original commit addressed an issue where the application would crash immediately if initial authentication failed. The changes introduce a more graceful error handling mechanism, deferring the exit to allow for potential further processing or context. However, the cherry-pick encountered merge conflicts that need to be resolved manually. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request aims to fix an issue where the CLI would crash if initial authentication failed, by deferring the exit until a later stage. It introduces an initialAuthFailed flag to track authentication status and moves the exit logic to occur before sandbox setup. The test file has been updated to reflect these changes in loadCliConfig mocks. No high or critical security vulnerabilities were found to be introduced by these changes. Please ensure that the merge conflicts are fully resolved before merging this PR.
|
Size Change: +106 B (0%) Total Size: 23.2 MB ℹ️ View Unchanged
|
0fa9a54
into
release/v0.26.0-preview.1-pr-17308
This PR automatically cherry-picks commit 87a0db2 to patch version v0.26.0-preview.1 in the preview release to create version 0.26.0-preview.2.
This cherry-pick resulted in merge conflicts that need manual resolution.
🔧 Next Steps:
📋 Files with conflicts:
The commit has been created with conflict markers for easier manual resolution.
🚨 Important: