fix(patch): cherry-pick 9866eb0 to release/v0.25.1-pr-17166 to patch version v0.25.1 and create version 0.25.2

[gemini-cli-robot]

This PR automatically cherry-picks commit 9866eb0 to patch version v0.25.1 in the stable release to create version 0.25.2.

[gemini-code-assist]

Summary of Changes

Hello @gemini-cli-robot, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request delivers a critical fix to the CLI's internal logic for selecting a default text editor. By refining the conditional assignment of editor commands, it ensures that users consistently get the expected editor experience across different operating systems, particularly when VISUAL or EDITOR environment variables are not explicitly defined. This change is part of an automated patch release process to maintain stability and correctness in the v0.25 series.

Highlights

• Editor Selection Logic Refinement: The logic for determining the default text editor (e.g., 'notepad' on Windows, 'vi' elsewhere) when environment variables VISUAL or EDITOR are not set has been refactored for clarity and correctness.
• Automated Patch Release: This pull request is an automated cherry-pick of a specific commit to create a new patch version v0.25.2 from the v0.25.1 stable release.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[github-actions]

Size Change: 0 B

Total Size: 23 MB

ℹ️ View Unchanged

Filename	Size
./bundle/gemini.js	23 MB
./bundle/sandbox-macos-permissive-closed.sb	1.03 kB
./bundle/sandbox-macos-permissive-open.sb	890 B
./bundle/sandbox-macos-permissive-proxied.sb	1.31 kB
./bundle/sandbox-macos-restrictive-closed.sb	3.29 kB
./bundle/sandbox-macos-restrictive-open.sb	3.36 kB
./bundle/sandbox-macos-restrictive-proxied.sb	3.56 kB

_{compressed-size-action}

[gemini-code-assist]

Code Review

This pull request correctly fixes a logic bug in determining the default editor. The previous implementation would incorrectly default to notepad on any platform if the VISUAL or EDITOR environment variables were set, due to incorrect operator precedence and grouping within the ternary condition. The updated code properly uses nullish coalescing to check for VISUAL and EDITOR first, falling back to a platform-specific default (notepad for Windows, vi otherwise) only if they are not defined. The fix is correct and effectively resolves the issue.