lower the default max retries to reduce contention#17975
Conversation
Summary of ChangesHello @sehoon38, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses system contention issues, particularly when facing frequent capacity-related failures. By reducing the default maximum number of retry attempts from 10 to 3, the system will now back off more quickly, thereby decreasing the overall load and potential for resource contention. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Hi @sehoon38, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this. We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines. Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed. Thank you for your understanding and for being a part of our community! |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request reduces the default maximum retry attempts from 10 to 3 to alleviate contention. While this change is logical, it will cause existing unit tests to fail as they are hardcoded to expect the previous default of 10. The tests in packages/core/src/utils/retry.test.ts must be updated to reflect the new default value of 3.
|
Size Change: -3 B (0%) Total Size: 23.6 MB ℹ️ View Unchanged
|
gemini-cli
Bot
added
the
priority/p1
sehoon38
force-pushed
the
sehoon/retry
branch
from
f4684db to
d285996
Compare
sehoon38
changed the title
gemini-cli
Bot
added
the
area/agent
|
/patch |
|
✅ Patch workflow(s) dispatched successfully! 📋 Details:
🔗 Track Progress: |
|
🚀 Patch PR Created! 📋 Patch Details:
📝 Next Steps:
🔗 Track Progress: |
|
🚀 Patch PR Created! 📋 Patch Details:
📝 Next Steps:
🔗 Track Progress: |
|
🚀 Patch Release Started! 📋 Release Details:
⏳ Status: The patch release is now running. You'll receive another update when it completes. 🔗 Track Progress: |
|
✅ Patch Release Complete! 📦 Release Details:
🎉 Status: Your patch has been successfully released and published to npm! 📝 What's Available:
🔗 Links: |
3 participants
Summary
With high rate of capacity related failures, lower the max retries to reduce the contention.
Details
The default used to be 3, but bumped up to 10 with the new UX giving them visibility of how many retries happening and allowing them to cancel anytime. Lowering to reduce the overall contention.
Related Issues
Fixes #17982
How to Validate
Pre-Merge Checklist