fix(patch): cherry-pick e1bd1d2 to release/v0.27.0-preview.6-pr-18209 to patch version v0.27.0-preview.6 and create version 0.27.0-preview.7#18226
Conversation
Summary of ChangesHello @gemini-cli-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request is an automated cherry-pick to patch a preview release, specifically updating the retry mechanism within the core package. The primary goal is to centralize and standardize the default maximum number of retry attempts by introducing a dedicated constant, thereby improving maintainability and consistency in how retry logic is configured and reported. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request cherry-picks a fix that corrects the reported number of maximum retry attempts. The changes introduce a DEFAULT_MAX_ATTEMPTS constant in retry.ts and use it in geminiChat.ts to ensure the onRetry event reports the correct value, which was previously hardcoded to an incorrect number. This change improves consistency and correctly reflects the retry behavior to the user. The implementation is correct and I have no further suggestions.
|
Size Change: +142 B (0%) Total Size: 23.5 MB ℹ️ View Unchanged
|
This PR automatically cherry-picks commit e1bd1d2 to patch version v0.27.0-preview.6 in the preview release to create version 0.27.0-preview.7.