Skip to content

fix(patch): cherry-pick a8b4c38 to release/v0.27.0-pr-18161 to patch version v0.27.0 and create version 0.27.1#18393

Merged
mattKorwel merged 1 commit into
release/v0.27.0-pr-18161from
hotfix/v0.27.0/0.27.1/stable/cherry-pick-a8b4c38/pr-18161
Feb 5, 2026
Merged

fix(patch): cherry-pick a8b4c38 to release/v0.27.0-pr-18161 to patch version v0.27.0 and create version 0.27.1#18393
mattKorwel merged 1 commit into
release/v0.27.0-pr-18161from
hotfix/v0.27.0/0.27.1/stable/cherry-pick-a8b4c38/pr-18161

Conversation

@gemini-cli-robot

Copy link
Copy Markdown
Collaborator

This PR automatically cherry-picks commit a8b4c38 to patch version v0.27.0 in the stable release to create version 0.27.1.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @gemini-cli-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates enhanced telemetry logging for numerical model routing decisions. It refines the metadata associated with routing outcomes by explicitly naming the 'NumericalClassifier' as the source and introduces new telemetry fields to capture granular details such as the reasoning behind a routing decision, the enablement status of numerical routing, and the specific classifier threshold applied. These changes improve the observability and debugging capabilities for model routing within the system.

Highlights

  • Telemetry Enhancement: Introduced new telemetry keys and logging logic to capture detailed information about numerical model routing decisions, including reasoning, whether numerical routing was enabled, and the classifier threshold used.
  • Metadata Renaming: Updated the 'source' metadata field from 'Classifier' to 'NumericalClassifier' in the NumericalClassifierStrategy implementation and its corresponding tests for clarity and specificity.
  • Test Coverage: Added new unit tests to ensure that the enhanced telemetry logging for numerical routing events functions as expected.
Changelog
  • packages/core/src/routing/strategies/numericalClassifierStrategy.test.ts
    • Updated test assertions to reflect the NumericalClassifier source in routing metadata.
  • packages/core/src/routing/strategies/numericalClassifierStrategy.ts
    • Changed the source metadata field from 'Classifier' to 'NumericalClassifier' for routing decisions.
  • packages/core/src/telemetry/clearcut-logger/clearcut-logger.test.ts
    • Added a new test case to verify logging of numerical routing fields in ModelRoutingEvent.
  • packages/core/src/telemetry/clearcut-logger/clearcut-logger.ts
    • Implemented logic to log numerical routing reasoning, enablement status, and classifier threshold as part of ModelRoutingEvent telemetry.
  • packages/core/src/telemetry/clearcut-logger/event-metadata-key.ts
    • Defined new EventMetadataKey enums (GEMINI_CLI_ROUTING_REASONING, GEMINI_CLI_ROUTING_NUMERICAL_ENABLED, GEMINI_CLI_ROUTING_CLASSIFIER_THRESHOLD) for numerical routing telemetry.
  • packages/core/src/telemetry/loggers.test.ts
    • Added a new test to confirm that logModelRouting correctly handles and logs numerical routing fields.
  • packages/core/src/telemetry/metrics.test.ts
    • Corrected the casing of 'classifier' to 'Classifier' in routing.decision_source within test expectations.
Activity
  • No specific activity (comments, reviews, etc.) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request cherry-picks a commit to a release branch, introducing fixes and enhancements for the telemetry of the numerical classifier routing strategy. The changes include making the telemetry source name more specific (from 'Classifier' to 'NumericalClassifier') and adding new telemetry fields for reasoning, feature enablement status, and the classifier threshold. The corresponding tests have been updated to reflect these changes. The implementation is sound and improves the observability of the routing strategy. I have not found any high or critical issues.

@github-actions

github-actions Bot commented Feb 5, 2026

Copy link
Copy Markdown

Size Change: +688 B (0%)

Total Size: 23.5 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 23.5 MB +688 B (0%)
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B

compressed-size-action

@gemini-cli gemini-cli Bot added the status/need-issue Pull requests that need to have an associated issue. label Feb 5, 2026
@mattKorwel mattKorwel merged commit 7f91d75 into release/v0.27.0-pr-18161 Feb 5, 2026
26 checks passed
@mattKorwel mattKorwel deleted the hotfix/v0.27.0/0.27.1/stable/cherry-pick-a8b4c38/pr-18161 branch February 5, 2026 19:25
@sripasg sripasg added the size/m A medium sized PR label Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/m A medium sized PR status/need-issue Pull requests that need to have an associated issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants