Skip to content

Refactor Github Action per b/485167538#19350

Closed
google-admin wants to merge 1 commit into
release/v0.25.0-nightly.20260110.b08b0d715from
lsc-1771383500.864145
Closed

Refactor Github Action per b/485167538#19350
google-admin wants to merge 1 commit into
release/v0.25.0-nightly.20260110.b08b0d715from
lsc-1771383500.864145

Conversation

@google-admin

Copy link
Copy Markdown
Contributor

This is a http://go/LSC run by http://go/ghss to automatically refactor your Github Actions per http://b/485167538.

This is a PR to help you upgrade to the latest standards in Github Actions.

Please merge this PR to accept the changes. NOTE: if you do not accept this PR, it may be force merged by the GHSS team. See http://b/485167538 for more details.

@google-admin google-admin requested a review from a team as a code owner February 18, 2026 02:58
@google-admin google-admin requested a review from a team as a code owner February 18, 2026 02:58
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @google-admin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request systematically refactors the way input variables are consumed within several custom GitHub Actions. The primary goal is to enhance the robustness and security of these actions by transitioning from direct interpolation of inputs.<input-name> within run scripts to using explicitly defined environment variables. This standardized approach mitigates risks associated with shell command injection and ensures consistent variable handling across the workflows.

Highlights

  • GitHub Actions Refactoring: Refactored multiple GitHub Actions to improve security and reliability by explicitly passing input variables as environment variables to shell scripts, rather than directly interpolating them.
  • Enhanced Input Handling: Updated all affected action.yml files to define input variables within the env block for run steps, ensuring proper shell evaluation and preventing potential injection issues.
  • Automated Update: This change was automatically generated by an internal tool (ghss) to align with the latest GitHub Actions standards, as per internal bug b/485167538.
Changelog
  • .github/actions/create-pull-request/action.yml
    • Updated the create-pull-request action to pass all relevant inputs (branch name, PR title, body, base branch) as environment variables to the gh pr create command.
  • .github/actions/npm-auth-token/action.yml
    • Modified the npm-auth-token action to use environment variables for github-token, package-name, and various wombat-token inputs within its shell script.
  • .github/actions/publish-release/action.yml
    • Adjusted the publish-release action to use environment variables for release-tag when creating the release branch.
    • Updated the package version update step to use an environment variable for release-version.
    • Refactored npm publish and install steps to utilize environment variables for dry-run, core-package-name, release-version, cli-package-name, and a2a-package-name.
    • Changed the GitHub release creation step to pass release-tag, release_branch.outputs.BRANCH_NAME, and previous-tag as environment variables.
    • Modified the release branch cleanup step to use an environment variable for release_branch.outputs.BRANCH_NAME.
  • .github/actions/push-docker/action.yml
    • Updated the push-docker action to pass ref-name as an environment variable to the branch name determination step.
  • .github/actions/push-sandbox/action.yml
    • Modified the push-sandbox action to use environment variables for github-ref-name and github-sha in the image tag determination step.
    • Updated the docker build step to use an environment variable for image_tag.outputs.FINAL_TAG.
    • Adjusted the docker publish step to use an environment variable for docker_build.outputs.uri.
  • .github/actions/setup-npmrc/action.yml
    • Refactored the setup-npmrc action to pass github-token as an environment variable when configuring the .npmrc file.
  • .github/actions/tag-npm-release/action.yml
    • Updated the tag-npm-release action to use environment variables for core-package-name, version, and channel in the npm dist-tag add commands for core, cli, and a2a packages.
    • Modified the dry run log message to use environment variables for channel, version, cli-package-name, core-package-name, and a2a-package-name.
  • .github/actions/verify-release/action.yml
    • Adjusted the verify-release action to use environment variables for expected-version and npm-package in both the gemini --version and npx --prefer-online verification steps.
Ignored Files
  • Ignored by pattern: .github/workflows/** (7)
    • .github/workflows/chained_e2e.yml
    • .github/workflows/ci.yml
    • .github/workflows/deflake.yml
    • .github/workflows/eval.yml
    • .github/workflows/release-patch-3-release.yml
    • .github/workflows/release-promote.yml
    • .github/workflows/trigger_e2e.yml
Activity
  • This pull request was automatically generated by the ghss tool as part of an automated refactoring effort.
  • The PR description indicates that it may be force-merged by the GHSS team if not accepted, suggesting a mandatory update.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions

Copy link
Copy Markdown

Size Change: -2 B (0%)

Total Size: 22.3 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 22.3 MB -2 B (0%)
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B

compressed-size-action

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces an automated refactoring across several GitHub Actions workflows. The changes consistently apply a security best practice by replacing direct injection of context variables into shell scripts with environment variables. This mitigates the risk of shell injection vulnerabilities. I have reviewed all the modifications, and they are correctly implemented and align with the goal of improving security without altering the actions' functionality. The changes are approved.

@gemini-cli gemini-cli Bot added the status/need-issue Pull requests that need to have an associated issue. label Feb 18, 2026
@google-admin google-admin deleted the lsc-1771383500.864145 branch February 18, 2026 18:14
@sripasg sripasg added the size/m A medium sized PR label Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/m A medium sized PR status/need-issue Pull requests that need to have an associated issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants