Skip to content

Refactor Github Action per b/485167538#19383

Closed
google-admin wants to merge 1 commit into
release/v0.29.0-preview.1from
lsc-1771403179.3553958
Closed

Refactor Github Action per b/485167538#19383
google-admin wants to merge 1 commit into
release/v0.29.0-preview.1from
lsc-1771403179.3553958

Conversation

@google-admin

Copy link
Copy Markdown
Contributor

This is a http://go/LSC run by http://go/ghss to automatically refactor your Github Actions per http://b/485167538.

This is a PR to help you upgrade to the latest standards in Github Actions.

Please merge this PR to accept the changes. NOTE: if you do not accept this PR, it may be force merged by the GHSS team. See http://b/485167538 for more details.

@gemini-cli

gemini-cli Bot commented Feb 18, 2026

Copy link
Copy Markdown
Contributor

Hi @google-admin, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this.

We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines.

Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed.

Thank you for your understanding and for being a part of our community!

@gemini-cli

gemini-cli Bot commented Feb 18, 2026

Copy link
Copy Markdown
Contributor

Hi there! Thank you for your contribution to Gemini CLI.

To improve our contribution process and better track changes, we now require all pull requests to be associated with an existing issue, as announced in our recent discussion and as detailed in our CONTRIBUTING.md.

This pull request is being closed because it is not currently linked to an issue. Once you have updated the description of this PR to link an issue (e.g., by adding Fixes #123 or Related to #123), it will be automatically reopened.

How to link an issue:
Add a keyword followed by the issue number (e.g., Fixes #123) in the description of your pull request. For more details on supported keywords and how linking works, please refer to the GitHub Documentation on linking pull requests to issues.

Thank you for your understanding and for being a part of our community!

@gemini-cli gemini-cli Bot closed this Feb 18, 2026
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @google-admin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a significant refactoring across several GitHub Actions to align with updated best practices for input handling. The core change involves transitioning from direct interpolation of inputs within run steps to using explicitly defined environment variables. This standardization aims to improve the reliability and clarity of how action inputs are consumed by shell scripts, ensuring a more consistent and secure execution environment for automated workflows.

Highlights

  • GitHub Actions Refactoring: All modified GitHub Actions have been refactored to standardize how input parameters are accessed within run scripts. Instead of direct interpolation, inputs are now first assigned to environment variables and then referenced via these variables.
  • Improved Input Handling: This change enhances the robustness and maintainability of the actions by explicitly defining inputs as environment variables, which can help prevent unexpected parsing issues and improve script readability.
Changelog
  • .github/actions/create-pull-request/action.yml
    • Updated the create-pull-request action to use environment variables for accessing input parameters within the run script.
  • .github/actions/npm-auth-token/action.yml
    • Modified the npm-auth-token action to standardize input parameter access through environment variables.
  • .github/actions/publish-release/action.yml
    • Refactored multiple steps within the publish-release action to use environment variables for input and output access, improving consistency.
  • .github/actions/push-docker/action.yml
    • Adjusted the push-docker action to use an environment variable for the ref-name input.
  • .github/actions/push-sandbox/action.yml
    • Updated the push-sandbox action to use environment variables for various inputs and step outputs.
  • .github/actions/setup-npmrc/action.yml
    • Modified the setup-npmrc action to use an environment variable for the github-token input.
  • .github/actions/tag-npm-release/action.yml
    • Refactored all npm dist-tag add and dry run logging steps in tag-npm-release to use environment variables for inputs.
  • .github/actions/verify-release/action.yml
    • Updated the verify-release action to use environment variables for expected-version and npm-package inputs.
Ignored Files
  • Ignored by pattern: .github/workflows/** (8)
    • .github/workflows/chained_e2e.yml
    • .github/workflows/ci.yml
    • .github/workflows/deflake.yml
    • .github/workflows/eval.yml
    • .github/workflows/evals-nightly.yml
    • .github/workflows/release-patch-3-release.yml
    • .github/workflows/release-promote.yml
    • .github/workflows/trigger_e2e.yml
Activity
  • This pull request was automatically generated by ghss to refactor GitHub Actions per b/485167538.
  • The author google-admin has indicated that this PR should be merged to upgrade to the latest standards, and may be force merged if not accepted.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors GitHub Actions workflows to enhance security by passing context variables (from inputs and steps) to shell scripts via environment variables, thereby mitigating shell injection vulnerabilities. The changes are correct and align with the intended security improvement, and no vulnerabilities or critical issues were found during the review.

@google-admin google-admin deleted the lsc-1771403179.3553958 branch February 18, 2026 22:50
@sripasg sripasg added the size/m A medium sized PR label Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/m A medium sized PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants