Skip to content

Refactor Github Action per b/485167538#19431

Closed
google-admin wants to merge 1 commit into
release/v0.28.0-preview.5-pr-18406from
lsc-1771423592.380452
Closed

Refactor Github Action per b/485167538#19431
google-admin wants to merge 1 commit into
release/v0.28.0-preview.5-pr-18406from
lsc-1771423592.380452

Conversation

@google-admin

Copy link
Copy Markdown
Contributor

This is a http://go/LSC run by http://go/ghss to automatically refactor your Github Actions per http://b/485167538.

This is a PR to help you upgrade to the latest standards in Github Actions.

Please merge this PR to accept the changes. NOTE: if you do not accept this PR, it may be force merged by the GHSS team. See http://b/485167538 for more details.

@gemini-cli

gemini-cli Bot commented Feb 18, 2026

Copy link
Copy Markdown
Contributor

Hi there! Thank you for your contribution to Gemini CLI.

To improve our contribution process and better track changes, we now require all pull requests to be associated with an existing issue, as announced in our recent discussion and as detailed in our CONTRIBUTING.md.

This pull request is being closed because it is not currently linked to an issue. Once you have updated the description of this PR to link an issue (e.g., by adding Fixes #123 or Related to #123), it will be automatically reopened.

How to link an issue:
Add a keyword followed by the issue number (e.g., Fixes #123) in the description of your pull request. For more details on supported keywords and how linking works, please refer to the GitHub Documentation on linking pull requests to issues.

Thank you for your understanding and for being a part of our community!

@gemini-cli gemini-cli Bot closed this Feb 18, 2026
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @google-admin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors several GitHub Actions to align with updated best practices and security standards. The core change involves transitioning input variables to explicit environment variables within run steps, enhancing security by preventing direct interpolation of inputs into shell commands. This automated update ensures that the workflows adhere to the latest recommended configurations.

Highlights

  • GitHub Actions Refactoring: Updated multiple GitHub Actions (create-pull-request, npm-auth-token, publish-release, push-docker, push-sandbox, setup-npmrc, tag-npm-release, verify-release) to pass input variables to run steps via explicit env blocks.
  • Enhanced Security and Best Practices: Migrated from direct inputs interpolation within shell scripts to using env variables, which is a recommended security practice for GitHub Actions to prevent shell injection vulnerabilities.
  • Automated Change: This refactor was automatically generated by a tool (LSC/GHSS) to ensure compliance with the latest GitHub Actions standards, as indicated by the PR description.
Changelog
  • .github/actions/create-pull-request/action.yml
    • Updated the gh pr create command to use INPUTS_BRANCH_NAME, INPUTS_PR_TITLE, INPUTS_PR_BODY, and INPUTS_BASE_BRANCH environment variables instead of direct inputs for pull request creation.
    • Added INPUTS_BRANCH_NAME, INPUTS_PR_TITLE, INPUTS_PR_BODY, and INPUTS_BASE_BRANCH to the env block for the run step.
  • .github/actions/npm-auth-token/action.yml
    • Modified the run script to use INPUTS_GITHUB_TOKEN, INPUTS_PACKAGE_NAME, INPUTS_WOMBAT_TOKEN_CLI, INPUTS_WOMBAT_TOKEN_CORE, and INPUTS_WOMBAT_TOKEN_A2A_SERVER environment variables for determining the authentication token.
    • Added INPUTS_GITHUB_TOKEN, INPUTS_PACKAGE_NAME, INPUTS_WOMBAT_TOKEN_CLI, INPUTS_WOMBAT_TOKEN_CORE, and INPUTS_WOMBAT_TOKEN_A2A_SERVER to the env block.
  • .github/actions/publish-release/action.yml
    • Updated the 'release_branch' step to use INPUTS_RELEASE_TAG environment variable.
    • Added INPUTS_RELEASE_TAG to the env block for the 'release_branch' step.
    • Updated the 'Update package versions' step to use INPUTS_RELEASE_VERSION environment variable.
    • Added INPUTS_RELEASE_VERSION to the env block for the 'Update package versions' step.
    • Modified the npm publish command and npm dist-tag rm command to use INPUTS_DRY_RUN and INPUTS_CORE_PACKAGE_NAME environment variables.
    • Added INPUTS_DRY_RUN and INPUTS_CORE_PACKAGE_NAME to the env block for the npm publish step.
    • Updated the npm install command to use INPUTS_CORE_PACKAGE_NAME, INPUTS_RELEASE_VERSION, INPUTS_CLI_PACKAGE_NAME, and INPUTS_A2A_PACKAGE_NAME environment variables.
    • Added INPUTS_CORE_PACKAGE_NAME, INPUTS_RELEASE_VERSION, INPUTS_CLI_PACKAGE_NAME, and INPUTS_A2A_PACKAGE_NAME to the env block for the npm install step.
    • Modified the npm publish command for CLI package to use INPUTS_DRY_RUN and INPUTS_CLI_PACKAGE_NAME environment variables.
    • Added INPUTS_DRY_RUN and INPUTS_CLI_PACKAGE_NAME to the env block for the CLI package npm publish step.
    • Modified the npm publish command for A2A package to use INPUTS_DRY_RUN and INPUTS_A2A_PACKAGE_NAME environment variables.
    • Added INPUTS_DRY_RUN and INPUTS_A2A_PACKAGE_NAME to the env block for the A2A package npm publish step.
    • Updated the gh release create command to use INPUTS_RELEASE_TAG, STEPS_RELEASE_BRANCH_OUTPUTS_BRANCH_NAME, and INPUTS_PREVIOUS_TAG environment variables.
    • Added INPUTS_RELEASE_TAG, STEPS_RELEASE_BRANCH_OUTPUTS_BRANCH_NAME, and INPUTS_PREVIOUS_TAG to the env block for the gh release create step.
    • Updated the release branch cleanup command to use STEPS_RELEASE_BRANCH_OUTPUTS_BRANCH_NAME environment variable.
    • Added STEPS_RELEASE_BRANCH_OUTPUTS_BRANCH_NAME to the env block for the release branch cleanup step.
  • .github/actions/push-docker/action.yml
    • Updated the REF_NAME assignment to use INPUTS_REF_NAME environment variable.
    • Added INPUTS_REF_NAME to the env block for the 'branch_name' step.
  • .github/actions/push-sandbox/action.yml
    • Updated SHELL_TAG_NAME and FINAL_TAG assignments to use INPUTS_GITHUB_REF_NAME and INPUTS_GITHUB_SHA environment variables.
    • Added INPUTS_GITHUB_REF_NAME and INPUTS_GITHUB_SHA to the env block for the 'image_tag' step.
    • Updated the npm run build:sandbox command to use STEPS_IMAGE_TAG_OUTPUTS_FINAL_TAG environment variable.
    • Added STEPS_IMAGE_TAG_OUTPUTS_FINAL_TAG to the env block for the 'build' step.
    • Updated the docker push command to use STEPS_DOCKER_BUILD_OUTPUTS_URI environment variable.
    • Added STEPS_DOCKER_BUILD_OUTPUTS_URI to the env block for the 'publish' step.
  • .github/actions/setup-npmrc/action.yml
    • Updated the _authToken line to use INPUTS_GITHUB_TOKEN environment variable.
    • Added INPUTS_GITHUB_TOKEN to the env block.
  • .github/actions/tag-npm-release/action.yml
    • Updated the npm dist-tag add command for core package to use INPUTS_CORE_PACKAGE_NAME, INPUTS_VERSION, and INPUTS_CHANNEL environment variables.
    • Added INPUTS_CORE_PACKAGE_NAME, INPUTS_VERSION, and INPUTS_CHANNEL to the env block for the core package tagging step.
    • Updated the npm dist-tag add command for cli package to use INPUTS_CLI_PACKAGE_NAME, INPUTS_VERSION, and INPUTS_CHANNEL environment variables.
    • Added INPUTS_CLI_PACKAGE_NAME, INPUTS_VERSION, and INPUTS_CHANNEL to the env block for the cli package tagging step.
    • Updated the npm dist-tag add command for a2a package to use INPUTS_A2A_PACKAGE_NAME, INPUTS_VERSION, and INPUTS_CHANNEL environment variables.
    • Added INPUTS_A2A_PACKAGE_NAME, INPUTS_VERSION, and INPUTS_CHANNEL to the env block for the a2a package tagging step.
    • Updated the dry run log message to use INPUTS_CHANNEL, INPUTS_VERSION, INPUTS_CLI_PACKAGE_NAME, INPUTS_CORE_PACKAGE_NAME, and INPUTS_A2A_PACKAGE_NAME environment variables.
    • Added INPUTS_CHANNEL, INPUTS_VERSION, INPUTS_CLI_PACKAGE_NAME, INPUTS_CORE_PACKAGE_NAME, and INPUTS_A2A_PACKAGE_NAME to the env block for the dry run log step.
  • .github/actions/verify-release/action.yml
    • Updated the version comparison and error message to use INPUTS_EXPECTED_VERSION and INPUTS_NPM_PACKAGE environment variables.
    • Added INPUTS_EXPECTED_VERSION and INPUTS_NPM_PACKAGE to the env block for the version verification step.
    • Updated the npx command and error message to use INPUTS_NPM_PACKAGE and INPUTS_EXPECTED_VERSION environment variables.
    • Added INPUTS_NPM_PACKAGE and INPUTS_EXPECTED_VERSION to the env block for the npx run verification step.
Ignored Files
  • Ignored by pattern: .github/workflows/** (8)
    • .github/workflows/chained_e2e.yml
    • .github/workflows/ci.yml
    • .github/workflows/deflake.yml
    • .github/workflows/eval.yml
    • .github/workflows/evals-nightly.yml
    • .github/workflows/release-patch-3-release.yml
    • .github/workflows/release-promote.yml
    • .github/workflows/trigger_e2e.yml
Activity
  • This pull request was automatically created by the google-admin bot as part of a large-scale refactoring (LSC) initiative.
  • The changes are intended to upgrade GitHub Actions to the latest standards as per internal bug b/485167538.
  • The PR description indicates that it may be force-merged if not accepted, highlighting its importance for compliance.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request contains automated refactoring of GitHub Actions to enhance security. The changes systematically replace direct context access within shell scripts with environment variables, which is a best practice to prevent shell injection vulnerabilities. I have reviewed the changes across all modified action files and they appear to be correctly and consistently implemented. This is a valuable security improvement and I have no further recommendations.

@google-admin google-admin deleted the lsc-1771423592.380452 branch February 18, 2026 22:51
@sripasg sripasg added the size/m A medium sized PR label Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/m A medium sized PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants