Skip to content

Add explicit color-convert dependency#19460

Merged
chrstnb merged 2 commits into
mainfrom
cb/updatedeps
Feb 18, 2026
Merged

Add explicit color-convert dependency#19460
chrstnb merged 2 commits into
mainfrom
cb/updatedeps

Conversation

@chrstnb

@chrstnb chrstnb commented Feb 18, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes an issue where the release or installation would fail in some environments due to color-convert (a transitive dependency of chalk and ansi-styles) not being properly resolved or hoisted.

Details

This was removed last week #18749

Related Issues

Fixes #19448

How to Validate

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed)
  • Noted breaking changes (if any)
  • Validated on required platforms/methods:
    • MacOS
      • npm run
      • npx
      • Docker
      • Podman
      • Seatbelt
    • Windows
      • npm run
      • npx
      • Docker
    • Linux
      • npm run
      • npx
      • Docker

@chrstnb chrstnb requested a review from a team as a code owner February 18, 2026 19:34
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @chrstnb, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where the 'color-convert' package, a transitive dependency of 'chalk' and 'ansi-styles', was not being properly resolved or hoisted in some environments, leading to installation or release failures. By explicitly adding 'color-convert' as a direct dependency to the 'packages/cli' manifest, this change ensures its consistent availability and improves the overall stability of the build process.

Highlights

  • Dependency Resolution Fix: Explicitly added 'color-convert' as a direct dependency to 'packages/cli/package.json' to resolve issues with its transitive dependency resolution during installation or release.
  • Lockfile Update: Updated 'package-lock.json' to reflect the new 'color-convert' dependency and to include 'peer: true' flags for several other packages, ensuring consistent dependency trees.
Changelog
  • package-lock.json
    • Added 'color-convert' as a direct dependency for the 'packages/cli' entry.
    • Updated numerous package entries to include the 'peer: true' flag.
  • packages/cli/package.json
    • Added 'color-convert' with version '^2.0.1' to the 'dependencies' list.
Activity
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly addresses an issue with transitive dependency resolution by adding color-convert as an explicit dependency to packages/cli. This is the standard solution for such problems. The changes in package.json and package-lock.json are appropriate to resolve the issue. I have reviewed the changes and found no high or critical issues to report.

@github-actions

github-actions Bot commented Feb 18, 2026

Copy link
Copy Markdown

Size Change: -2 B (0%)

Total Size: 24.5 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 24.5 MB -2 B (0%)
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B
./bundle/sandbox-macos-strict-open.sb 4.82 kB 0 B
./bundle/sandbox-macos-strict-proxied.sb 5.02 kB 0 B

compressed-size-action

@chrstnb chrstnb enabled auto-merge February 18, 2026 19:45
@chrstnb chrstnb added this pull request to the merge queue Feb 18, 2026
Merged via the queue into main with commit 858918f Feb 18, 2026
27 checks passed
@chrstnb chrstnb deleted the cb/updatedeps branch February 18, 2026 20:08
@chrstnb

chrstnb commented Feb 18, 2026

Copy link
Copy Markdown
Contributor Author

/patch release

@github-actions

Copy link
Copy Markdown

Patch workflow(s) dispatched successfully!

📋 Details:

  • Channels: stable,preview
  • Commit: 858918fe31c00a92baf3c02537e89c6a51ca802f
  • Workflows Created: 2

🔗 Track Progress:

@github-actions

Copy link
Copy Markdown

🚀 Patch PR Created!

📋 Patch Details:

📝 Next Steps:

  1. Review and approve the hotfix PR: #19480
  2. Once merged, the patch release will automatically trigger
  3. You'll receive updates here when the release completes

🔗 Track Progress:

@github-actions

Copy link
Copy Markdown

🚀 Patch Release Started!

📋 Release Details:

  • Environment: prod
  • Channel: stable → publishing to npm tag latest
  • Version: v0.29.0
  • Hotfix PR: Merged ✅
  • Release Branch: release/v0.29.0-pr-19460

⏳ Status: The patch release is now running. You'll receive another update when it completes.

🔗 Track Progress:

@github-actions

Copy link
Copy Markdown

Patch Release Complete!

📦 Release Details:

  • Version: 0.29.1
  • NPM Tag: latest
  • Channel: stable
  • Dry Run: false

🎉 Status: Your patch has been successfully released and published to npm!

📝 What's Available:

🔗 Links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/s A small PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gemini CLI threw errors, I had to manually kill the process.

3 participants