fix(patch): cherry-pick 261788c to release/v0.30.0-preview.0-pr-19453 to patch version v0.30.0-preview.0 and create version 0.30.0-preview.1#19490
Conversation
…ble = true and fetch errors should be fatal (#19453)
Summary of ChangesHello @gemini-cli-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request cherry-picks a critical commit to patch a preview release, focusing on refining the client-side handling of administrative controls. The changes introduce a new Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request refactors the logic for handling admin controls by introducing an adminControlsApplicable flag from the server, replacing the previous reliance on HTTP 403 status codes. The client-side logic is updated to use this flag for applying settings and managing polling. Error handling for the initial fetch is also improved to be more explicit by throwing exceptions on failure. The changes are well-tested and represent a solid improvement in robustness and clarity. I have no comments on the changes.
|
Size Change: -79 B (0%) Total Size: 24.5 MB ℹ️ View Unchanged
|
0114b3e
into
release/v0.30.0-preview.0-pr-19453
… to patch version v0.30.0-preview.0 and create version 0.30.0-preview.1 (google-gemini#19490) Co-authored-by: Shreya Keshive <shreyakeshive@google.com>
This PR automatically cherry-picks commit 261788c to patch version v0.30.0-preview.0 in the preview release to create version 0.30.0-preview.1.