fix(patch): cherry-pick c43500c to release/v0.29.2-pr-19502 to patch version v0.29.2 and create version 0.29.3#19522
Conversation
Summary of ChangesHello @gemini-cli-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request automates a patch release ( Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request cherry-picks a fix to add punycode as a dependency and configure esbuild to resolve it correctly. This is likely to address build issues related to the deprecation of the built-in punycode module in newer Node.js versions. The changes are generally correct and well-implemented. I have one high-severity suggestion to improve maintainability by centralizing the new esbuild alias configuration, preventing potential configuration drift between packages in the monorepo.
| alias: { | ||
| punycode: 'punycode/', | ||
| }, |
There was a problem hiding this comment.
This hardcoded alias duplicates the one defined in the root esbuild.config.js. To improve maintainability and prevent configuration drift in this monorepo, it's better to define common aliases in a single shared file.
For example, you could create a file like scripts/esbuild-aliases.js:
// scripts/esbuild-aliases.js
export const commonAliases = {
punycode: 'punycode/',
};Then, import and use it in both this file and the root esbuild.config.js:
// packages/vscode-ide-companion/esbuild.js
import { commonAliases } from '../../scripts/esbuild-aliases.js';
// ...
alias: commonAliases,
// ...This ensures that common build configurations are managed in one place.
|
Size Change: +7.62 kB (+0.03%) Total Size: 23.9 MB
ℹ️ View Unchanged
|
…version v0.29.2 and create version 0.29.3 (google-gemini#19522) Co-authored-by: Jacob Richman <jacob314@gmail.com>
This PR automatically cherry-picks commit c43500c to patch version v0.29.2 in the stable release to create version 0.29.3.