Skip to content

fix(patch): cherry-pick c43500c to release/v0.29.2-pr-19502 to patch version v0.29.2 and create version 0.29.3#19522

Merged
skeshive merged 1 commit into
release/v0.29.2-pr-19502from
hotfix/v0.29.2/0.29.3/stable/cherry-pick-c43500c/pr-19502
Feb 19, 2026
Merged

fix(patch): cherry-pick c43500c to release/v0.29.2-pr-19502 to patch version v0.29.2 and create version 0.29.3#19522
skeshive merged 1 commit into
release/v0.29.2-pr-19502from
hotfix/v0.29.2/0.29.3/stable/cherry-pick-c43500c/pr-19502

Conversation

@gemini-cli-robot

Copy link
Copy Markdown
Collaborator

This PR automatically cherry-picks commit c43500c to patch version v0.29.2 in the stable release to create version 0.29.3.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @gemini-cli-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request automates a patch release (v0.29.3) by cherry-picking a commit that addresses a dependency resolution issue. The core change involves explicitly adding the punycode package as a direct dependency and configuring esbuild to correctly alias and bundle it across different build configurations, ensuring its proper availability in the compiled output.

Highlights

  • Dependency Management: The punycode package was explicitly added as a direct dependency in package.json and package-lock.json, ensuring its availability for production builds.
  • Build Configuration: Esbuild configurations in esbuild.config.js and packages/vscode-ide-companion/esbuild.js were updated to include aliases for punycode, resolving potential bundling issues.
  • Patch Release Automation: This pull request represents an automated cherry-pick to create a patch release (v0.29.3) for a stable version (v0.29.2).
Changelog
  • esbuild.config.js
    • Introduced a commonAliases object for punycode resolution.
    • Applied commonAliases to the cliConfig alias settings.
    • Applied commonAliases to the a2aServerConfig alias settings.
  • package-lock.json
    • Added punycode as a new direct dependency.
    • Removed the devOptional flag from the punycode entry.
  • package.json
    • Added punycode version ^2.3.1 to dependencies.
  • packages/vscode-ide-companion/esbuild.js
    • Added an alias for punycode to ensure correct bundling.
Activity
  • This pull request was automatically generated by gemini-cli-robot to cherry-pick commit c43500c to the release/v0.29.2-pr-19502 branch, creating version 0.29.3.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@skeshive skeshive enabled auto-merge (squash) February 19, 2026 14:43

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request cherry-picks a fix to add punycode as a dependency and configure esbuild to resolve it correctly. This is likely to address build issues related to the deprecation of the built-in punycode module in newer Node.js versions. The changes are generally correct and well-implemented. I have one high-severity suggestion to improve maintainability by centralizing the new esbuild alias configuration, preventing potential configuration drift between packages in the monorepo.

Comment on lines +52 to +54
alias: {
punycode: 'punycode/',
},

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This hardcoded alias duplicates the one defined in the root esbuild.config.js. To improve maintainability and prevent configuration drift in this monorepo, it's better to define common aliases in a single shared file.

For example, you could create a file like scripts/esbuild-aliases.js:

// scripts/esbuild-aliases.js
export const commonAliases = {
  punycode: 'punycode/',
};

Then, import and use it in both this file and the root esbuild.config.js:

// packages/vscode-ide-companion/esbuild.js
import { commonAliases } from '../../scripts/esbuild-aliases.js';
// ...
alias: commonAliases,
// ...

This ensures that common build configurations are managed in one place.

@github-actions

Copy link
Copy Markdown

Size Change: +7.62 kB (+0.03%)

Total Size: 23.9 MB

Filename Size Change
./bundle/gemini.js 23.9 MB +7.62 kB (+0.03%)
ℹ️ View Unchanged
Filename Size
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB
./bundle/sandbox-macos-permissive-open.sb 890 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB

compressed-size-action

@skeshive skeshive disabled auto-merge February 19, 2026 15:04
@skeshive skeshive merged commit f581ebd into release/v0.29.2-pr-19502 Feb 19, 2026
26 of 27 checks passed
@skeshive skeshive deleted the hotfix/v0.29.2/0.29.3/stable/cherry-pick-c43500c/pr-19502 branch February 19, 2026 15:04
kuishou68 pushed a commit to iOfficeAI/gemini-cli-pro that referenced this pull request Feb 27, 2026
…version v0.29.2 and create version 0.29.3 (google-gemini#19522)

Co-authored-by: Jacob Richman <jacob314@gmail.com>
@sripasg sripasg added the size/s A small PR label Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/s A small PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants