fix(patch): cherry-pick aa9163d to release/v0.30.0-preview.3-pr-19991 to patch version v0.30.0-preview.3 and create version 0.30.0-preview.4#20040
Conversation
Summary of ChangesHello @gemini-cli-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request automates the cherry-picking of a commit that enhances the system's model availability policies. It introduces the capability to utilize Gemini 3.1 models, including a specific version for custom tools, by updating the logic that determines which model chain to use based on new configuration options and authentication context. This ensures that the application can leverage the latest model capabilities when enabled. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Size Change: +379 B (0%) Total Size: 24.5 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Code Review
The pull request introduces changes to how model policy chains are resolved, specifically to support Gemini 3.1 models with and without custom tools. This involves updating policyCatalog.test.ts to include new test cases for Gemini 3.1 chains, modifying policyCatalog.ts to dynamically resolve the preview model based on Gemini 3.1 and custom tool flags, and updating policyHelpers.test.ts and policyHelpers.ts to incorporate these new flags into the policy chain resolution logic. The changes ensure that the correct Gemini 3.1 model is selected when useGemini31 and useCustomToolModel flags are enabled.
| definePolicy({ model: DEFAULT_GEMINI_FLASH_MODEL, isLastResort: true }), | ||
| ]; | ||
|
|
||
| const PREVIEW_CHAIN: ModelPolicyChain = [ | ||
| definePolicy({ model: PREVIEW_GEMINI_MODEL }), | ||
| definePolicy({ model: PREVIEW_GEMINI_FLASH_MODEL, isLastResort: true }), | ||
| ]; | ||
|
|
||
| const FLASH_LITE_CHAIN: ModelPolicyChain = [ |
There was a problem hiding this comment.
The PREVIEW_CHAIN constant has been removed. While the logic is now inlined within getModelPolicyChain, removing a constant that was previously used might reduce readability if the chain structure was meant to be easily identifiable and reusable. Consider if this chain might be reused in other contexts or if its structure warrants being a named constant for clarity.
09c6514
into
release/v0.30.0-preview.3-pr-19991
… to patch version v0.30.0-preview.3 and create version 0.30.0-preview.4 (google-gemini#20040) Co-authored-by: Sehoon Shon <sshon@google.com>
This PR automatically cherry-picks commit aa9163d to patch version v0.30.0-preview.3 in the preview release to create version 0.30.0-preview.4.