Skip to content

fix(patch): cherry-pick d96bd05 to release/v0.29.6-pr-19867 to patch version v0.29.6 and create version 0.29.7#20111

Merged
sehoon38 merged 1 commit into
release/v0.29.6-pr-19867from
hotfix/v0.29.6/0.29.7/stable/cherry-pick-d96bd05/pr-19867
Feb 24, 2026
Merged

fix(patch): cherry-pick d96bd05 to release/v0.29.6-pr-19867 to patch version v0.29.6 and create version 0.29.7#20111
sehoon38 merged 1 commit into
release/v0.29.6-pr-19867from
hotfix/v0.29.6/0.29.7/stable/cherry-pick-d96bd05/pr-19867

Conversation

@gemini-cli-robot

Copy link
Copy Markdown
Collaborator

This PR automatically cherry-picks commit d96bd05 to patch version v0.29.6 in the stable release to create version 0.29.7.

@github-actions

Copy link
Copy Markdown

You already have 7 pull requests open. Please work on getting existing PRs merged before opening more.

@github-actions github-actions Bot closed this Feb 24, 2026
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @gemini-cli-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where a newly introduced Gemini 3.1 preview model, specifically one with custom tools capabilities, was not being correctly recognized by the system's access control mechanisms. The changes ensure that the application accurately identifies this model and grants users with the corresponding quota the necessary access to preview features, thereby maintaining consistent functionality and user experience for advanced AI capabilities.

Highlights

  • Preview Model Recognition: The isPreviewModel utility function has been updated to correctly identify the new PREVIEW_GEMINI_3_1_CUSTOM_TOOLS_MODEL.
  • Quota-Based Access Logic: The Config class's logic for determining user access to preview models now leverages the updated isPreviewModel function, ensuring that users with the new Gemini 3.1 custom tools model in their quota are granted appropriate access.
  • Test Coverage: New test cases have been added to both config.test.ts and models.test.ts to validate the correct recognition and access granting for the gemini-3.1-pro-preview and PREVIEW_GEMINI_3_1_CUSTOM_TOOLS_MODEL.
Changelog
  • packages/core/src/config/config.test.ts
    • Added a test case to ensure hasAccessToPreviewModel is correctly updated when the quota includes the gemini-3.1-pro-preview model.
  • packages/core/src/config/config.ts
    • Modified the refreshUserQuota method to use the isPreviewModel helper for determining preview model access, allowing for more flexible model identification.
  • packages/core/src/config/models.test.ts
    • Included a test case to verify that isPreviewModel correctly identifies PREVIEW_GEMINI_3_1_CUSTOM_TOOLS_MODEL as a preview model.
  • packages/core/src/config/models.ts
    • Updated the isPreviewModel function to recognize PREVIEW_GEMINI_3_1_CUSTOM_TOOLS_MODEL as a valid preview model.
Activity
  • This pull request was automatically created to cherry-pick commit d96bd05d368a7315fdf106a6de95e299d97adc18 to the release/v0.29.6-pr-19867 branch.
  • The purpose of this cherry-pick is to patch version v0.29.6 and create version 0.29.7.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request cherry-picks a fix to add support for new preview models. The core change in packages/core/src/config/config.ts refactors the preview model access check to use the isPreviewModel helper function, which is a significant improvement over the previous hardcoded value, making the system more extensible. The isPreviewModel function itself is updated in packages/core/src/config/models.ts to include PREVIEW_GEMINI_3_1_CUSTOM_TOOLS_MODEL. The accompanying test files (config.test.ts and models.test.ts) are updated with relevant test cases to ensure the new logic and models are correctly handled. The changes are correct, well-structured, and improve the overall maintainability of the code. I have no concerns with this pull request.

@sehoon38 sehoon38 reopened this Feb 24, 2026
@github-actions

Copy link
Copy Markdown

Size Change: +53 B (0%)

Total Size: 23.9 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 23.9 MB +53 B (0%)
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B

compressed-size-action

@gemini-cli gemini-cli Bot added the status/need-issue Pull requests that need to have an associated issue. label Feb 24, 2026
@sehoon38 sehoon38 merged commit e84f901 into release/v0.29.6-pr-19867 Feb 24, 2026
32 of 51 checks passed
@sehoon38 sehoon38 deleted the hotfix/v0.29.6/0.29.7/stable/cherry-pick-d96bd05/pr-19867 branch February 24, 2026 01:48
kuishou68 pushed a commit to iOfficeAI/gemini-cli-pro that referenced this pull request Feb 27, 2026
…version v0.29.6 and create version 0.29.7 (google-gemini#20111)

Co-authored-by: Bryan Morgan <bryanmorgan@google.com>
@sripasg sripasg added the size/s A small PR label Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/s A small PR status/need-issue Pull requests that need to have an associated issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants