fix(patch): cherry-pick d96bd05 to release/v0.29.6-pr-19867 to patch version v0.29.6 and create version 0.29.7#20111
Conversation
|
You already have 7 pull requests open. Please work on getting existing PRs merged before opening more. |
Summary of ChangesHello @gemini-cli-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue where a newly introduced Gemini 3.1 preview model, specifically one with custom tools capabilities, was not being correctly recognized by the system's access control mechanisms. The changes ensure that the application accurately identifies this model and grants users with the corresponding quota the necessary access to preview features, thereby maintaining consistent functionality and user experience for advanced AI capabilities. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request cherry-picks a fix to add support for new preview models. The core change in packages/core/src/config/config.ts refactors the preview model access check to use the isPreviewModel helper function, which is a significant improvement over the previous hardcoded value, making the system more extensible. The isPreviewModel function itself is updated in packages/core/src/config/models.ts to include PREVIEW_GEMINI_3_1_CUSTOM_TOOLS_MODEL. The accompanying test files (config.test.ts and models.test.ts) are updated with relevant test cases to ensure the new logic and models are correctly handled. The changes are correct, well-structured, and improve the overall maintainability of the code. I have no concerns with this pull request.
|
Size Change: +53 B (0%) Total Size: 23.9 MB ℹ️ View Unchanged
|
…version v0.29.6 and create version 0.29.7 (google-gemini#20111) Co-authored-by: Bryan Morgan <bryanmorgan@google.com>
This PR automatically cherry-picks commit d96bd05 to patch version v0.29.6 in the stable release to create version 0.29.7.